Repository navigation
Fix provider runtime readiness and browser attachment #546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| import { createRequire } from "node:module"; | ||
| import path from "node:path"; | ||
| import type * as CursorSdkModuleTypes from "@cursor/sdk"; | ||
|
|
||
| export type CursorSdkModule = typeof CursorSdkModuleTypes; | ||
|
|
||
| const requireFromRuntime = createRequire( | ||
| typeof __filename === "string" ? __filename : path.join(process.cwd(), "package.json"), | ||
| ); | ||
|
|
||
| let sdkModule: CursorSdkModule | null = null; | ||
| let sdkModulePromise: Promise<CursorSdkModule> | null = null; | ||
|
|
||
| function errorText(error: unknown): string { | ||
| if (error instanceof Error) return `${error.name}: ${error.message}`; | ||
| return String(error); | ||
| } | ||
|
|
||
| export function isCursorSdkResolutionError(error: unknown): boolean { | ||
| const message = errorText(error); | ||
| const code = error && typeof error === "object" | ||
| ? String((error as { code?: unknown }).code ?? "") | ||
| : ""; | ||
| return code === "ERR_MODULE_NOT_FOUND" | ||
| || code === "MODULE_NOT_FOUND" | ||
| || /Cannot find package ['"]@cursor\/sdk['"]/i.test(message) | ||
| || /Cannot find module ['"]@cursor\/sdk['"]/i.test(message); | ||
| } | ||
|
|
||
| function loadCursorSdkWithRequire(originalError: unknown): CursorSdkModule { | ||
| try { | ||
| return requireFromRuntime("@cursor/sdk") as CursorSdkModule; | ||
| } catch (fallbackError) { | ||
| if (isCursorSdkResolutionError(originalError)) { | ||
| const error = new Error( | ||
| `Failed to load @cursor/sdk via dynamic import or packaged runtime resolution. import=${errorText(originalError)} require=${errorText(fallbackError)}`, | ||
| ); | ||
| (error as { cause?: unknown }).cause = originalError; | ||
| throw error; | ||
| } | ||
| throw originalError instanceof Error ? originalError : fallbackError; | ||
|
greptile-apps[bot] marked this conversation as resolved.
Resolved
|
||
| } | ||
| } | ||
|
|
||
| export async function loadCursorSdk(): Promise<CursorSdkModule> { | ||
| if (sdkModule) return sdkModule; | ||
| if (!sdkModulePromise) { | ||
| sdkModulePromise = import("@cursor/sdk") | ||
| .catch((error) => { | ||
| if (!isCursorSdkResolutionError(error)) throw error; | ||
| return loadCursorSdkWithRequire(error); | ||
| }) | ||
| .then((loaded) => { | ||
| sdkModule = loaded; | ||
| return loaded; | ||
| }) | ||
| .catch((error) => { | ||
| sdkModulePromise = null; | ||
| throw error; | ||
| }); | ||
| } | ||
| return sdkModulePromise; | ||
| } | ||
|
|
||
| export function resetCursorSdkLoaderForTests(): void { | ||
| sdkModule = null; | ||
| sdkModulePromise = null; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| import { createRequire } from "node:module"; | ||
| import path from "node:path"; | ||
| import type * as DroidSdkModuleTypes from "@factory/droid-sdk"; | ||
|
|
||
| export type DroidSdkModule = typeof DroidSdkModuleTypes; | ||
|
|
||
| const requireFromRuntime = createRequire( | ||
| typeof __filename === "string" ? __filename : path.join(process.cwd(), "package.json"), | ||
| ); | ||
|
coderabbitai[bot] marked this conversation as resolved.
Resolved
|
||
|
|
||
| let sdkModule: DroidSdkModule | null = null; | ||
| let sdkModulePromise: Promise<DroidSdkModule> | null = null; | ||
|
|
||
| function errorText(error: unknown): string { | ||
| if (error instanceof Error) return `${error.name}: ${error.message}`; | ||
| return String(error); | ||
| } | ||
|
|
||
| export function isDroidSdkResolutionError(error: unknown): boolean { | ||
| const message = errorText(error); | ||
| const code = error && typeof error === "object" | ||
| ? String((error as { code?: unknown }).code ?? "") | ||
| : ""; | ||
| return code === "ERR_MODULE_NOT_FOUND" | ||
| || code === "MODULE_NOT_FOUND" | ||
| || /Cannot find package ['"]@factory\/droid-sdk['"]/i.test(message) | ||
| || /Cannot find module ['"]@factory\/droid-sdk['"]/i.test(message); | ||
| } | ||
|
|
||
| function loadDroidSdkWithRequire(originalError: unknown): DroidSdkModule { | ||
| try { | ||
| return requireFromRuntime("@factory/droid-sdk") as DroidSdkModule; | ||
| } catch (fallbackError) { | ||
| if (isDroidSdkResolutionError(originalError)) { | ||
| const error = new Error( | ||
| `Failed to load @factory/droid-sdk via dynamic import or packaged runtime resolution. import=${errorText(originalError)} require=${errorText(fallbackError)}`, | ||
| ); | ||
| (error as { cause?: unknown }).cause = originalError; | ||
| throw error; | ||
| } | ||
| throw originalError instanceof Error ? originalError : fallbackError; | ||
| } | ||
| } | ||
|
|
||
| export async function loadDroidSdk(): Promise<DroidSdkModule> { | ||
| if (sdkModule) return sdkModule; | ||
| if (!sdkModulePromise) { | ||
| sdkModulePromise = import("@factory/droid-sdk") | ||
| .catch((error) => { | ||
| if (!isDroidSdkResolutionError(error)) throw error; | ||
| return loadDroidSdkWithRequire(error); | ||
| }) | ||
| .then((loaded) => { | ||
| sdkModule = loaded; | ||
| return loaded; | ||
| }) | ||
| .catch((error) => { | ||
| sdkModulePromise = null; | ||
| throw error; | ||
| }); | ||
| } | ||
| return sdkModulePromise; | ||
| } | ||
|
|
||
| export function resetDroidSdkLoaderForTests(): void { | ||
| sdkModule = null; | ||
| sdkModulePromise = null; | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.