Optimizing Files And Run Tab - #294
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Owner
Author
|
@copilot review but do not make fixes |
|
Important Review skippedToo many files! This PR contains 166 files, which is 16 over the limit of 150. To get a review, narrow the scope: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (23)
📒 Files selected for processing (166)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
|
@greptile review |
|
Capy auto-review is paused for this organization because the monthly auto-review limit has been reached. Increase the limit or turn it off in billing settings to resume automatic reviews. |
Contributor
Reviewed commits 12cd3a3 and 77b9b43 without applying fixes. I don’t see a new blocking issue from this pass; main remaining risk is regression surface due to breadth of runtime/session changes, so targeted follow-up validation around Files/Run flows is still recommended. Reference: 12cd3a3. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Owner
Author
|
@copilot review but do not make fixes |
Owner
Author
|
@greptile review |
Copilot stopped work on behalf of
arul28 due to an error
May 14, 2026 08:11
arul28
added a commit
that referenced
this pull request
Jun 15, 2026
ADE's Work-tab Claude chat (Agent SDK) locked MCP to managed-only (allowManagedMcpServersOnly + empty allowlist) — a context/perf trim from #294 that silently stripped the user's configured MCP servers (~/.claude.json, project .mcp.json) from chats, making the SDK chat strictly less capable than an `ade` CLI session for the same task (e.g. iOS automation / WebDriverAgent). ENABLE_TOOL_SEARCH now keeps large tool catalogs cheap, so the trim is no longer worth the capability loss. - Remove the unconditional lock so normal chats load user MCP via settingSources. - Keep lightweight side-jobs (auto-title / lane-naming) lean via strictMcpConfig. - Orchestration sessions keep managed-only isolation in their own block. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
arul28
added a commit
that referenced
this pull request
Jun 15, 2026
) * fix(chat): load user MCP servers in Claude chats (parity with CLI) ADE's Work-tab Claude chat (Agent SDK) locked MCP to managed-only (allowManagedMcpServersOnly + empty allowlist) — a context/perf trim from #294 that silently stripped the user's configured MCP servers (~/.claude.json, project .mcp.json) from chats, making the SDK chat strictly less capable than an `ade` CLI session for the same task (e.g. iOS automation / WebDriverAgent). ENABLE_TOOL_SEARCH now keeps large tool catalogs cheap, so the trim is no longer worth the capability loss. - Remove the unconditional lock so normal chats load user MCP via settingSources. - Keep lightweight side-jobs (auto-title / lane-naming) lean via strictMcpConfig. - Orchestration sessions keep managed-only isolation in their own block. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * ship: iter 1 — harden normal-chat MCP test (Greptile P2) Assert strictMcpConfig is absent in the normal-chat test, guarding against it leaking into non-lightweight sessions (which would silently re-block the user's MCP servers). Mirrors the lightweight test's positive assertion. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * ship: iter 2 — isolate MCP for orchestration lead sessions (Codex P1) Removing the base MCP lock let draft / role-marked orchestration leads (no bundle yet → orchestration MCP block skipped) load user/project MCP servers, which could restore tool capability the read-only lead is denied via disallowedTools. Apply strictMcpConfig whenever isOrchestrationLeadSession is true, not only when the orchestration MCP server exists. strictMcpConfig still permits the programmatic orchestration server for bundled leads. Workers/validators do real work and keep user MCP. Regression tests: draft-lead and role-marked-lead now assert strictMcpConfig. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Describe the change.
What Changed
Key files and behaviors.
Validation
How you tested.
Risks
Anything to watch.
Greptile Summary
This PR optimizes the Files and Run tabs by splitting
LaneRuntimeBar's single polling cycle into separate health (10 s) and routing (30 s) intervals, simplifyingWorkStartSurfaceto delegate all draft kinds throughAgentChatPane, and adding inline agent-CLI continuation UI so ended CLI sessions can be resumed without leaving the Work view.refreshRuntimeStateintorefreshHealthStateandrefreshRoutingState, each with its own sequence counter and timer.ClosedCliSessionSurfacewith terminal-snapshot rendering, content-derived React keys, andWorkCliContinuationComposerwith permission/model pickers position-computed fromgetBoundingClientRect.contextTarget: WorkSidebarContextTargetprop.Confidence Score: 5/5
Safe to merge; changes are largely additive and previous review concerns have been addressed.
The polling split, CLI continuation UI, and PTY context insertion are well-structured. Permission picker now uses getBoundingClientRect, React keys are content-derived, ANSI stripping reuses the canonical helper, and the permission-mode reset effect uses primitive string dependencies.
No files require special attention; the WorkSidebar PTY write error path could benefit from user-visible feedback but is non-blocking.
Important Files Changed
if (normalized === ".") return undefinedguard; "." is now stored explicitly as cwd in config; downstream normalizedCwd logic is unaffected.Prompt To Fix All With AI
Reviews (4): Last reviewed commit: "ship: iteration 1 — address Greptile rev..." | Re-trigger Greptile