Skip to content

worker: deploy account-directory without R2 binding until the subscription is enabled #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arul28 merged 1 commit into from
Aug 19, 2026
Merged

worker: deploy account-directory without R2 binding until the subscription is enabled #1126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 25 additions & 12 deletions apps/account-directory/wrangler.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,26 @@
// is NOT created by deploying — run `wrangler r2 bucket create` first (see
// README, "Diagnostic report uploads"). Missing binding is handled: the route
// answers 503 and the in-app button reports that sending is unavailable.
"r2_buckets": [
{
"binding": "DIAGNOSTICS",
"bucket_name": "ade-diagnostics"
}
],
//
// TEMPORARILY UNBOUND (v1.2.61 release). R2 is not enabled on this Cloudflare
// account: bucket creation fails with "Please enable R2 through the Cloudflare
// Dashboard [code: 10042]", and a Worker bound to a bucket that cannot exist
// fails to start — which would take down machine registration and pairing for
// every user, not just diagnostics. Leaving DIAGNOSTICS unbound is the
// designed degradation: `DiagnosticsEnv` types it `DIAGNOSTICS?: R2Bucket`,
// the upload route answers 503, and the in-app "Send to ADE" button reports
// that sending is unavailable. Every other route is unaffected.
//
// TO RE-ENABLE, once the R2 subscription is added to the account:
// 1. revert this commit (restores both `r2_buckets` blocks verbatim)
// 2. npx wrangler r2 bucket create ade-diagnostics
// npx wrangler r2 bucket create ade-diagnostics-production
// 3. add the 90-day expiry lifecycle rule to BOTH buckets — nothing in the
// Worker ever deletes a report (see README, step 4)
// 4. npm run deploy:production
// 5. verify the fail-closed probes: garbage Bearer -> 401, >512 KiB -> 413
//
// "r2_buckets": [{ "binding": "DIAGNOSTICS", "bucket_name": "ade-diagnostics" }],
"env": {
"production": {
"name": "ade-account-directory-production",
Expand All @@ -68,13 +82,12 @@
"database_id": "38ebe0bb-ac4d-4b39-b73e-bab2f0092971",
"migrations_dir": "migrations"
}
],
"r2_buckets": [
{
"binding": "DIAGNOSTICS",
"bucket_name": "ade-diagnostics-production"
}
]
// DIAGNOSTICS is unbound here for the same reason as the top-level
// environment — see the note above `env` for why, and for the exact
// re-enable steps. The production bucket was `ade-diagnostics-production`.
//
// "r2_buckets": [{ "binding": "DIAGNOSTICS", "bucket_name": "ade-diagnostics-production" }]
}
}
}
Loading