Move the import hint below the activity graph and scale the wordmark - #1103
Conversation
The 'Import your chats from outside ADE' pill sat between the composer and the launch shelf, where it took the shelf's row and overlapped it. It is now the last row of the draft column, below the activity graph. The wordmark was sized h-auto + max-h-full, which left the image at its natural height once the box shrank, so a short window cropped it against the enclosing overflow-hidden wrapper instead of scaling it. h-full + object-contain fills the aspect-ratio box and letterboxes inside it. ImportFloatingBadge carries shrink-0 on its own root rather than a wrapper in the caller, so a retired hint renders zero nodes and spends none of the column's gap.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
arul28
changed the title
|
@cursor review |
|
Skipping Bugbot: Bugbot is disabled for this repository. Visit the Bugbot dashboard to update your settings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (3)
Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe empty chat state now scales the ADE logo proportionally and places the import-session badge at the bottom of the empty-state column. The badge cannot shrink in the flex layout. Tests cover dismissal and projects without an opted-in root. ChangesEmpty-state layout
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The PR makes localized layout and documentation updates, with no actionable merge-blocking risk remaining. Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Two fixes to the Work draft (new-chat) column. Both live in the shared renderer, so they land on the desktop app and the hosted web client at once.
Import hint overlapped the launch shelf
The "Import your chats from outside ADE" pill rendered between the composer and the launch shelf, where it took the shelf's row and overlapped it. It is now the last row of the column, below the activity graph — a hint sitting under everything it can act on, rather than a band cutting the stack in two.
Moving it also un-breaks an existing CSS rule:
[data-chat-composer-wrapper]:has(+ .ade-chat-launch-shelf)suppresses the composer's drop shadow so it doesn't paint over the shelf, and the badge sitting between them made that adjacent-sibling selector fail whenever the hint was visible.Wordmark cropped instead of scaling
The logo was sized
h-auto max-h-full, which left the image at its natural height once its box shrank, so a height-constrained window cropped the wordmark against the enclosingoverflow-hiddenwrapper.h-full w-full object-containfills the aspect-ratio box and letterboxes inside it, so the shrink is proportional.The logo is 1012x493 against a 560/300 box, so it is width-constrained at rest — rendering is pixel-identical when there is room, and the change only bites on the shrink path.
Zero-node when retired
ImportFloatingBadgecarriesshrink-0on its own root rather than a wrapper in the caller. It returnsnullonce dismissed or when there is no project, and the column is agap-3flex stack, so a wrapper would have spent 12px on a hint that is no longer there. Both null branches are now pinned by tests.Verification
importSessionssuite: 40 passedNot visually verified: Playwright browsers are not installed on the dev machine and Safari was wedged under memory pressure. The CSS reasoning was independently checked against the real image and box dimensions.
Summary by CodeRabbit