Skip to content

Connections: restructure the this-computer card - #1038

Merged
arul28 merged 1 commit into
mainfrom
ade/connection-panel-ui
Aug 5, 2026
Merged

Connections: restructure the this-computer card#1038
arul28 merged 1 commit into
mainfrom
ade/connection-panel-ui

Conversation

@arul28

@arul28 arul28 commented Aug 5, 2026

Copy link
Copy Markdown
Owner

The this-computer card led with a generic laptop glyph and three lines the reader could not act on — a readiness verdict, a route breakdown, and a platform name the icon already implied. Pairing, the rarest path now that the ADE account is the primary way to connect, took the most vertical space.

What changed

  • Platform logo in the identity tile. AppleLogo / WindowsLogo / LinuxLogo, with Laptop as the fallback and the OS name as the tile's accessible label. Since the logo is the platform statement, the version line drops its · Windows suffix.
  • Inline rename. A pencil beside the name opens an inline input, mirroring the account page. It writes saveRuntimeName first — that is the value this card renders, so the change shows immediately — then mirrors to account.renameMachine so the account page and other clients agree. Best effort on the second write: a directory hiccup should not undo a rename the user can already see. Signed out, the pencil stays visible but disabled, with "Sign in to rename this computer".
  • Status only when actionable. acceptsConnectionsState is replaced by connectionProblem, which returns null for a healthy host. "Ready to accept connections" and "Reachable via …" are gone. A fault renders in the version line's slot, so the card never grows a line. A missing pairing code is no longer a fault — it is an ordinary state now that connecting runs through the account.
  • Pairing behind a disclosure. Header reads Pairing code · Set / · Not set. It opens closed on every mount and never remembers being opened. Opening it explains the code sets up a manual connection between this computer and another ADE client, like the mobile app.
  • Simpler account line. Just "Connected to your ADE account" — the published-route count was plumbing the reader could neither act on nor interpret.

Verification

  • npm run typecheck — clean across the desktop tree.
  • 505 tests pass across settings, remoteTargets, account, and webclient. New coverage for the three platform logos, the rename mirroring into the directory, the inert signed-out pencil, the disclosure never remembering its state, and the fault replacing the version line.
  • Renderer-only, no OS-specific code paths; Windows renders its own logo through the same branch as macOS and Linux.

🤖 Generated with Claude Code

ADE   Open in ADE  ·  ade/connection-panel-ui branch  ·  PR #1038

@vercel

vercel Bot commented Aug 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
ade Ignored Ignored Preview Aug 5, 2026 7:08pm

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@arul28, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 19 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ee4d8361-da9e-4ace-9fed-cd2ab179a818

📥 Commits

Reviewing files that changed from the base of the PR and between c21dba2 and 35219e8.

📒 Files selected for processing (3)
  • apps/desktop/src/renderer/components/settings/SyncDevicesSection.test.tsx
  • apps/desktop/src/renderer/components/settings/SyncDevicesSection.tsx
  • apps/desktop/src/renderer/components/settings/accountDirectorySummary.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

The card led with a generic laptop glyph and three lines the reader could
not act on -- a readiness verdict, a route breakdown, and the platform
name already implied by the icon. Pairing, the rarest path now that the
ADE account is the primary way to connect, took the most vertical space.

- Identity tile carries the platform logo (Apple/Windows/Linux), so the
  version line drops its redundant "- Windows" suffix.
- Name gains an inline pencil, mirroring the account page. It writes the
  runtime name first (what this card renders, so the change is visible
  immediately) then the account directory, so both surfaces agree.
- "Ready to accept connections" and "Reachable via ..." are gone. A
  status line now renders only for an actionable fault, in the version
  line's slot, so the card never grows. A missing pairing code is no
  longer treated as a fault -- it is an ordinary state.
- Pairing controls move behind a disclosure that opens closed every time
  and explains that the code is for a manual connection to another ADE
  client, like the mobile app.
- The account line drops its published-route count.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@arul28
arul28 force-pushed the ade/connection-panel-ui branch from 8efd592 to 35219e8 Compare August 5, 2026 19:08
@arul28
arul28 merged commit 81c0b94 into main Aug 5, 2026
36 checks passed
@arul28
arul28 deleted the ade/connection-panel-ui branch August 5, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant