[TEST]zapslog: fix all with slogtest, support inline group, ignore empty group. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: junya koyama <[email protected]>
Signed-off-by: junya koyama <[email protected]>
Signed-off-by: junya koyama <[email protected]>
arukiidou
changed the title
Signed-off-by: junya koyama <[email protected]>
Signed-off-by: junya koyama <[email protected]>
Signed-off-by: junya koyama <[email protected]>
arukiidou
force-pushed
the
feature/support-slog
branch
from
58a3672 to
e10aad1
Compare
Logger name is already tested in WithName. It doesn't need to be duplicated in every test.
This requires holding onto a slice instead of a single string to create the nested namespaces. The slice is cloned on each WithGroup call. We could probably do this more efficiently with an immutable tree of references, but deferring that for now. In the process, also make the addedNamespace business append during the record.Attrs loop instead of after. This is more efficient because we don't have to shift the slice over afterwards.
|
Close as main PR approved. |
abhinav
added a commit
to uber-go/zap
that referenced
this pull request
Feb 5, 2024
…oup. (#1408) This change adds a test based on testing/slogtest that verifies compliance with the slog handler contract (a draft of this was available in #1335), and fixes all resulting issues. The two remaining issues were: - `Group("", attrs)` should inline the new fields instead of creating a group with an empty name. This was fixed with the use of `zap.Inline`. - Groups without any attributes should not be created. That is, `logger.WithGroup("foo").Info("bar")` should not create an empty "foo" namespace (`"foo": {}`). This was fixed by keeping track of unapplied groups and applying them the first time a field is serialized. Following this change, slogtest passes as expected. Refs #1333 Resolves #1334, #1401, #1402 Supersedes #1263, #1335 ### TESTS - passed. arukiidou#1 - This also works in Go 1.22 --------- Signed-off-by: junya koyama <[email protected]> Co-authored-by: Abhinav Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.