Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Toolchain] Replace TSLint with ESLint #3467

Merged
merged 2 commits into from
Apr 29, 2020
Merged

Conversation

damassi
Copy link
Member

@damassi damassi commented Apr 29, 2020

Long time overdue, but this replaces TSLint with ESLint. I haven't addressed any of the the issues the linter raised in favor of disabling with comments. We'll need to find the time to uncomment each rule and address in code.

@damassi damassi requested a review from zephraph April 29, 2020 21:05
@artsy-peril artsy-peril bot added the Version: Patch Indicates that this PR should have a patch deploy, usually for bug fixes label Apr 29, 2020

// FIXME: Fix issues with React Hooks:
"react-hooks/rules-of-hooks": 0,
"react-hooks/exhaustive-deps": 0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@dzucconi
Copy link
Member

💌

@damassi damassi added Version: Minor Indicates that this PR should have a minor deploy, usually for new features and removed Version: Patch Indicates that this PR should have a patch deploy, usually for bug fixes labels Apr 29, 2020
@damassi damassi merged commit bef3aae into artsy:master Apr 29, 2020
@damassi damassi deleted the add-eslint branch April 29, 2020 21:32
@artsyit
Copy link
Contributor

artsyit commented Apr 29, 2020

🚀 PR was released in v26.30.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Version: Minor Indicates that this PR should have a minor deploy, usually for new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants