Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Reinstate sync-schema command #6459

Merged
merged 5 commits into from
Oct 13, 2020
Merged

chore: Reinstate sync-schema command #6459

merged 5 commits into from
Oct 13, 2020

Conversation

eessex
Copy link
Contributor

@eessex eessex commented Oct 12, 2020

In case we ever need to run manually,

  • Reinstate yarn command to sync schema

Copy link
Contributor

@iskounen iskounen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#mergeongreen

@joeyAghion
Copy link
Contributor

Out of curiosity, why was this necessary? Shouldn't Metaphysics be pushing any changes already?

@eessex
Copy link
Contributor Author

eessex commented Oct 12, 2020

@joeyAghion yes, metaphysics should be creating PRs for this automatically -- will investigate more fully, but at the moment we have drift in both volt and force. This pr will unblock deploys until we're able to find the reason sync-schema prs were not created for this change.

@damassi
Copy link
Member

damassi commented Oct 12, 2020

It's still good to have a manual button to press, just to be sure

@eessex
Copy link
Contributor Author

eessex commented Oct 12, 2020

Will wait on Metaphysics PR and update this to only add sync-schema command back. artsy/metaphysics#2769

@eessex eessex changed the title chore: Sync schema, reinstate sync-schema command chore: Reinstate sync-schema command Oct 12, 2020
@eessex eessex merged commit 1318f5f into master Oct 13, 2020
@artsy-peril artsy-peril bot mentioned this pull request Oct 13, 2020
@zephraph zephraph deleted the sync-schema branch October 23, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants