Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds relative-ci agent #14341

Merged
merged 1 commit into from
Aug 16, 2024
Merged

feat: adds relative-ci agent #14341

merged 1 commit into from
Aug 16, 2024

Conversation

dzucconi
Copy link
Member

@dzucconi dzucconi commented Aug 14, 2024 •
edited by jira bot
Loading

Closes DIA-793

We need to generate size diffs for bundle reports on pull requests. Testing out relative-ci.com — free for open source.

@dzucconi dzucconi requested review from damassi and a team August 14, 2024 12:53
@dzucconi dzucconi self-assigned this Aug 14, 2024
@dzucconi dzucconi force-pushed the DIA-793-generate-bundle-size-report-for-pull-requests branch 4 times, most recently from 2ed66e6 to 53fe0ee Compare August 14, 2024 13:05
egdbear
egdbear previously approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@egdbear egdbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

araujobarret
araujobarret reviewed Aug 14, 2024
View reviewed changes
Copy link
Contributor

@araujobarret araujobarret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we generate the artifacts to be stored within the job?
Might be nicer to take than the console

@dzucconi
Copy link
Member Author

@araujobarret I don't really follow what you're asking?

@araujobarret
Copy link
Contributor

image

Does this step generate something more visual to take a look(Artifacts in this case)?

@dzucconi
Copy link
Member Author

dzucconi commented Aug 14, 2024 •
edited
Loading

I'm using an external service. It will indeed generate something visual.

@araujobarret
Copy link
Contributor

That was my question, since it's not working yet and there's no screenshot in the PR I wanted to see where something more visual would come in(didn't look at the tool so much to say, maybe I should)

@dzucconi dzucconi force-pushed the DIA-793-generate-bundle-size-report-for-pull-requests branch from 53fe0ee to b55bcac Compare August 14, 2024 13:25
@dzucconi
Copy link
Member Author

Yeah, lemme get this working first 😄

@dzucconi dzucconi force-pushed the DIA-793-generate-bundle-size-report-for-pull-requests branch 3 times, most recently from 73ea553 to 7c2be74 Compare August 14, 2024 14:15
@relativeci RelativeCI
Copy link

relativeci bot commented Aug 14, 2024 •
edited
Loading

#6 Bundle Size — 9.68MiB (+100%).

⚠️ Baseline job is missing

Warning

Bundle contains 45 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
#6		      Baseline
No change  Initial JS 4.66MiB -
No change  Initial CSS 0B -
No change  Cache Invalidation 0% -
No change  Chunks 148 -
No change  Assets 151 -
No change  Modules 5667 -
No change  Duplicate Modules 475 -
No change  Duplicate Code 5.61% -
No change  Packages 292 -
No change  Duplicate Packages 42 -
Bundle size by type  no changes
                 Current
#6		      Baseline
No change  JS 9.47MiB (+100%) -
No change  Other 212.29KiB (+100%) -

Bundle analysis report Branch DIA-793-generate-bundle-size-rep... Project dashboard

Generated by RelativeCI Documentation Report issue

@dzucconi dzucconi force-pushed the DIA-793-generate-bundle-size-report-for-pull-requests branch from 7c2be74 to de67bdf Compare August 14, 2024 14:32
@damassi
Copy link
Member

damassi commented Aug 14, 2024

Ahh nice output, and not in house 👌

@araujobarret
Copy link
Contributor

Yeah, lemme get this working first 😄

a'ight 😂

is there a way to prevent generated files from being tagged as duplicated?

araujobarret
araujobarret previously approved these changes Aug 14, 2024
View reviewed changes
@dzucconi dzucconi force-pushed the DIA-793-generate-bundle-size-report-for-pull-requests branch from de67bdf to fdb4250 Compare August 14, 2024 14:53
damassi
damassi previously approved these changes Aug 14, 2024
View reviewed changes
starsirius
starsirius reviewed Aug 14, 2024
View reviewed changes
Dockerfile Show resolved Hide resolved
@dzucconi dzucconi force-pushed the DIA-793-generate-bundle-size-report-for-pull-requests branch 4 times, most recently from 9e04a83 to 9fc12a8 Compare August 16, 2024 12:11
@dzucconi dzucconi force-pushed the DIA-793-generate-bundle-size-report-for-pull-requests branch from 9fc12a8 to 859f1ef Compare August 16, 2024 12:23
@dzucconi dzucconi merged commit ea59206 into main Aug 16, 2024
13 checks passed
@dzucconi dzucconi deleted the DIA-793-generate-bundle-size-report-for-pull-requests branch August 16, 2024 12:39
@artsy-peril artsy-peril bot mentioned this pull request Aug 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starsirius starsirius starsirius left review comments

@joeyAghion joeyAghion joeyAghion left review comments

@araujobarret araujobarret araujobarret left review comments

@egdbear egdbear egdbear left review comments

@damassi damassi damassi left review comments

Assignees

@dzucconi dzucconi

Labels
Jira Synced
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dzucconi @araujobarret @damassi @joeyAghion @starsirius @egdbear