Include docs about i18n #10588
Include docs about i18n #10588
Conversation
docs/i18n.md
Outdated
|
|
||
| ## Context | ||
|
|
||
| Internationalization on Force was introduced as a hackathon project |
There was a problem hiding this comment.
Is there a tool that splits the lines like this? It doesn't make much sense for documentation.
There was a problem hiding this comment.
We were working on Notion and I guess I messed it up and I copied it from there, thanks for raising this!!
| value | ||
| 2. Once the PR is merged, it synchronizes with the third-party service | ||
| 3. `en-US` is updated there and a PR is automatically opened to the repository on GitHub | ||
| 4. The PR is merged by an Engineer so the project will include the updated locales |
There was a problem hiding this comment.
What's the reason for requiring an engineer to merge this last PR? Couldn't it be automated?
There was a problem hiding this comment.
Technically, it can. We can discuss what would be the ideal approach.
Since the changes will affect the user experience, I guess we would like to at least check it before releasing it.
A change from Buy Now to Purchase, for example, would probably be fine in most cases, but depending on the content, if it changes too much the length of a string, for example, it could break the layout or look weird in components that didn't expect that kind of change.
We setup react-i18next during [these changes](#9797), these docs contain instructions about the context, usage and next steps. Co-authored-by: Lidiane Taquehara <[email protected]> Co-authored-by: Leandro Linares <[email protected]>
There was a problem hiding this comment.
Docs look great @lidimayra 💯
One follow-up request here would be to move the locales folder under i18n/locales.
Co-authored-by: Pavlos Vinieratos <[email protected]>
The type of this PR is: Documentation
Description
We setup react-i18next during these changes, these docs contain instructions about the context, usage and next steps.