Skip to content

Commit

Permalink
[Refactor] Delete unused apps / assetts
Browse files Browse the repository at this point in the history
  • Loading branch information
damassi committed May 27, 2020
1 parent 05ae09f commit 92dd8ed
Show file tree
Hide file tree
Showing 16 changed files with 34 additions and 18 deletions.
1 change: 0 additions & 1 deletion src/desktop/analytics/inquiry_questionnaire.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ const analytics = window.analytics
// _per session_, and therefore can't rely on `once`, as subsequent
// inquiries would then not get tracked as there's no "hard jumps"
// between pages. See: https://github.com/artsy/force/pull/5232
// FIXME: Remove once A/B test completes
analyticsHooks.on(namespace(name), handler)
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export const artworkClient = () => {
const Artwork = require("desktop/models/artwork.coffee")
const ArtworkInquiry = require("desktop/models/artwork_inquiry.coffee")
const openInquiryQuestionnaireFor = require("desktop/components/inquiry_questionnaire/index.coffee")
const openAuctionBuyerPremium = require("desktop/apps/artwork/components/buyers_premium/index.coffee")
const openAuctionBuyerPremium = require("desktop/components/artworkBuyersPremium/index.coffee")
const ViewInRoomView = require("desktop/components/view_in_room/view.coffee")
const $ = require("jquery")
const mediator = require("desktop/lib/mediator.coffee")
Expand Down
1 change: 0 additions & 1 deletion src/desktop/assets/artist.js

This file was deleted.

2 changes: 0 additions & 2 deletions src/desktop/assets/artist.styl

This file was deleted.

1 change: 0 additions & 1 deletion src/desktop/assets/artwork.js

This file was deleted.

Empty file removed src/desktop/assets/collect.styl
Empty file.
1 change: 0 additions & 1 deletion src/desktop/assets/collect.ts

This file was deleted.

Empty file.
1 change: 0 additions & 1 deletion src/desktop/assets/identity_verification.ts

This file was deleted.

1 change: 0 additions & 1 deletion src/desktop/assets/order.js

This file was deleted.

1 change: 0 additions & 1 deletion src/desktop/assets/search2.js

This file was deleted.

Empty file removed src/desktop/assets/search2.styl
Empty file.
1 change: 0 additions & 1 deletion src/desktop/assets/viewing-room.tsx

This file was deleted.

22 changes: 22 additions & 0 deletions src/desktop/components/artworkBuyersPremium/index.coffee
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
modalize = require '../modalize/index.coffee'
Auction = require '../../models/auction.coffee'
fetchBuyersPremium = require '../buyers_premium/index.coffee'

module.exports = (auction_id) ->
$el = $('<div></div>')

view = render: -> $el: $el

modal = modalize view,
className: 'modalize artwork-auction-buyers-premium-modal'
dimensions: width: '700px'

auction = new Auction id: auction_id

modal.load (open) ->
auction.fetch().then ->
fetchBuyersPremium auction, (err, html) ->
$el.html html
open()

modal
10 changes: 10 additions & 0 deletions src/desktop/components/artworkBuyersPremium/index.styl
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
@require '../../../../../../components/buyers_premium'

.artwork-auction-buyers-premium-modal
//

.modalize-body
padding (gutter * 3)

h1
sans('l-headline')
8 changes: 1 addition & 7 deletions src/desktop/index.js → src/desktop/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ const app = (module.exports = require("express")())
// See: https://github.com/artsy/stitch/tree/master/src/internal for more info.
app.use(
stitchMiddleware({
// @ts-ignore
modules: globalReactModules,
wrapper: globalReactModules.StitchWrapper,
})
Expand All @@ -26,19 +27,13 @@ app.use(require("./apps/auctions2").app)
app.use(require("./apps/auction_lots"))

// TODO: Remove after AB test ends.
app.use(require("./apps/artist/server").app)
app.use(require("./apps/purchases/server").app)
app.use(require("./apps/conversations/server").app)
app.use(require("./apps/artwork/server").app)
app.use(require("./apps/collect/server").app)
app.use(require("./apps/search2/server").app)
app.use(require("./apps/art_keeps_going/server").app)
app.use(require("./apps/viewing-room/server").app)

app.use(require("./apps/artists"))
app.use(require("./apps/auction").app)
app.use(require("./apps/auction_support"))
app.use(require("./apps/identity_verification/server").app)
app.use(require("./apps/about"))
app.use(require("./apps/categories").app)
app.use(require("./apps/consign").app)
Expand All @@ -52,7 +47,6 @@ app.use(require("./apps/gene"))
app.use(require("./apps/geo"))
app.use(require("./apps/jobs"))
app.use(require("./apps/notifications"))
app.use(require("./apps/order/server").app)
app.use(require("./apps/personalize"))
app.use(require("./apps/press"))

Expand Down

0 comments on commit 92dd8ed

Please sign in to comment.