refactor(cleanup 🧹): Reverse image search #8898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damassi
approved these changes
Jun 16, 2023
dimatretyak
reviewed
Jun 17, 2023
| @@ -61,11 +61,6 @@ export const features: { [key: string]: FeatureDescriptor } = { | |||
| description: "Enable query prefetching", | |||
| echoFlagKey: "AREnableQueriesPrefetching", | |||
| }, | |||
| AREnableImageSearch: { | |||
There was a problem hiding this comment.
I think we can also remove useIsForeground since this hook is not used anywhere else
|
great work 🔥 |
|
hey let me know whats blocking you from using VisionCamera, I'm working on REA v3 support and in V3 the crash you linked will also be fixed due to a new way to initialize Frame Processors. Also; if you don't use Frame Processors you can disable them with a build flag and both of those issues should be fixed already |
|
Thanks a lot for the update @mrousavy! We temporarily disabled a feature that was not yet available and having the library was creating crashes with the feature disabled. We will revisit the feature at some point and will get the latest version 🙏 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves MOPLAT-830
Description
Cleans up reverse image search dependency due to some early crashes on android when opening the app in some devices.
Also blocked some reanimated upgrades.
More info on the crash can be found on the github issue here
Turning off the feature for now but we can easily bring it back if we decide with the diff of this PR.
cc @artsy/fx-devs
cc @artsy/mobile-platform
slack thread for more context can be found here
No visual changes since we never released.
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.