Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Upgrade Jest@29; upgrade [email protected] #8003

Merged
merged 25 commits into from
Jan 19, 2023

Conversation

damassi
Copy link
Member

@damassi damassi commented Jan 19, 2023

Addresses MOPLAT-517

Description

This PR upgrades Jest to 29 and reanimated to 2.13. Also updates react-native-vision-camera to 2.15, since 2.14 breaks when building for android. Needed to upgrade reanimated in support of latest Jest.

Also note that [email protected] is incompatible with RN.66 due to missing build for android! See missing react-native-reanimated-66 in unpkg. reanimated 2.13 includes it, however.

cc @artsy/mobile-platform

PR Checklist

  • I tested my changes on iOS / Android.
  • I added screenshots or videos to illustrate my changes.
  • I added Tests and Stories for my changes.
  • I added an app state migration.
  • I hid my changes behind a feature flag.
  • I have prefixed changes that need to be tested during a release QA with [NEEDS EXTERNAL QA] on the changelog.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@damassi damassi requested a review from pvinis January 19, 2023 00:04
@damassi damassi self-assigned this Jan 19, 2023
@damassi damassi force-pushed the damassi/update-deps branch 28 times, most recently from 82856a3 to d67f68f Compare January 19, 2023 04:13
@damassi damassi force-pushed the damassi/update-deps branch from 369e71f to e47d0c1 Compare January 19, 2023 19:39
@damassi damassi force-pushed the damassi/update-deps branch from e47d0c1 to 0f4915a Compare January 19, 2023 20:00
@damassi damassi changed the title chore(deps): Upgrade Jest@29; upgrade [email protected] chore(deps): Upgrade Jest@29; upgrade [email protected] Jan 19, 2023
@damassi damassi force-pushed the damassi/update-deps branch from 45a46db to ff003a7 Compare January 19, 2023 22:08
@@ -181,7 +182,7 @@
"react-native-svg": "9.13.3",
"react-native-url-polyfill": "1.3.0",
"react-native-view-shot": "3.4.0",
"react-native-vision-camera": "2.14.1",
"react-native-vision-camera": "2.15.2",
Copy link
Member Author

@damassi damassi Jan 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try running yarn install:all. I feel this might have podfile updates too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore this. I just saw it's there already.

@damassi damassi added the Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green label Jan 19, 2023
@artsy-peril artsy-peril bot merged commit d378d69 into main Jan 19, 2023
@artsy-peril artsy-peril bot deleted the damassi/update-deps branch January 19, 2023 23:11
@artsy-peril
Copy link
Contributor

artsy-peril bot commented Jan 20, 2023

jest-environment-jsdom

Author: Unknown

Description: undefined

Homepage: https://github.com/facebook/jest#readme

Createdalmost 7 years ago
Last Updated2 months ago
LicenseMIT
Maintainers6
Releases257
Direct Dependencies@jest/environment, @jest/fake-timers, @jest/types, @types/jsdom, @types/node, jest-mock, jest-util and jsdom
README

ERROR: No README data found!

New dependencies added: jest-environment-jsdom.

Generated by 🚫 dangerJS against f754ef6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jira Synced Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants