fix: Allow action sheets to open in front of modals#5664
Merged
MounirDhahri merged 2 commits intomasterfrom Oct 20, 2021
Merged
Conversation
Contributor
4af830d to
532d178
Compare
rajsam003
pushed a commit
that referenced
this pull request
Oct 27, 2021
* fix: Allow action sheets to open in front of modals * fix delete button
Gon4ar5
pushed a commit
that referenced
this pull request
Oct 27, 2021
* fix: Allow action sheets to open in front of modals * fix delete button
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type of this PR is: Bugfix
This PR resolves CX-2044
Description
Allows action sheets to open in front of modals on Android by wrapping the ActionSheet with a modal using the
useModaloption (react-native-action-sheet issue reference).PR Checklist (tick all before merging)
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes