Skip to content

Settings tabbed according to modules #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −7
Open

Settings tabbed according to modules #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions class-pos-settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@ public function settings_init() {
function( $args ) use ( $module ) {
echo '<p>' . esc_html( $module->get_module_description() ) . '</p>';
},
'pos'
'pos_' . $module->id
);
foreach ( $settings as $setting_id => $setting ) {
if ( empty( $setting['type'] ) || empty( $setting['name'] ) ) {
continue;
}
$option_name = $module->get_setting_option_name( $setting_id );
register_setting( 'pos', $option_name );
register_setting( 'pos_' . $module->id, $option_name );

add_settings_field(
'pos_field_' . $setting['name'],
Expand Down Expand Up @@ -67,7 +67,7 @@ function() use ( $setting, $option_name, $module ) {
}

},
'pos',
'pos_' . $module->id,
'pos_section_' . $module->id,
array()
);
Expand All @@ -81,8 +81,7 @@ function() use ( $setting, $option_name, $module ) {
* Add the top level menu page.
*/
public function options_page() {
add_submenu_page(
'options-general.php',
add_options_page(
'Personal OS',
'PersonalOS',
'manage_options',
Expand Down Expand Up @@ -110,16 +109,31 @@ public function page_html() {

// show error/update messages
settings_errors( 'pos_messages' );

$current_tab = isset( $_GET[ 'module' ] ) ? $_GET[ 'module' ] : 'notes';
?>

<div class="wrap">
<h1><?php echo esc_html( get_admin_page_title() ); ?></h1>
<nav class="nav-tab-wrapper">
<?php
foreach( $this->modules as $mod ) {
// CSS class for a current tab
$current = $mod->id === $current_tab ? ' nav-tab-active' : '';
// URL
$url = add_query_arg( array( 'page' => 'pos', 'module' => $mod->id ), '' );
// printing the tab link
echo "<a class=\"nav-tab{$current}\" href=\"{$url}\">{$mod->name}</a>";
}
?>
</nav>
<form action="options.php" method="post">
<?php
// output security fields for the registered setting "wporg"
settings_fields( 'pos' );
settings_fields( 'pos_' . $current_tab );
// output setting sections and their fields
// (sections are registered for "wporg", each field is registered to a specific section)
do_settings_sections( 'pos' );
do_settings_sections( 'pos_' . $current_tab );
// output save settings button
submit_button( 'Save Settings' );
?>
Expand Down