-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create WebAssembly version #18
Comments
Comment by jeromeetienne i love the idea. Now we need to find somebody to do it. any volunteers ? :) |
Comment by ZoltanVeres Any progress on this? |
Looks like emscripten can target WebAssembly with a flag https://github.com/kripken/emscripten/wiki/WebAssembly |
thanks @ptone I've added the build step for webassembly here ThorstenBux@6f88ec1 on a private branch. After build it fails to load the .wasm file. I haven't looked into as of why but maybe someone would like to pick it up. |
Any news on this? |
@ThorstenBux i built your repository, it appears that the various .wasm/.wast files are created in the /build directory, but are loaded from /examples.
I'm still trying to figure out where they're set during compilation, i figure there must be some compile option that allows to specify the actual path you want. |
@hjeldin Not sure what you are aiming for. Yes the wasm files are build to build directory that is what is configured. And the examples work by running a https server directly from the root directory. So the build directory is accessible to them. But currently the examples can't successfully load the wasm files afaik? |
Sorry @hjeldin after some research I found what you mean: emscripten-core/emscripten#5104 digging into that. |
@ThorstenBux It seems that enabling -s SINGLE_FILE=1 as compile flag results in ~10 MB for debug and a whopping 579KB for the minified version. I'm currently unable to test since, if i got it right, loading is now async.
This fundamentally changes the user workflow, so i can't tell if this is the best option available. |
@hjeldin you are awesome 👍 with your help I've got it working. One second I'll push to a branch including a working example. |
see here: https://github.com/ThorstenBux/jsartoolkit5/tree/webassembly-support example in examples/simple_image_wasm.html |
ok, I'd say it is working, documented and tests are written. Also opened a PR to pull into upstream and should be there soon. Please have a look and give feedback. I'm closing the issue for now. |
Adding NFT examples with WASM and a Worker.
Issue by jensarps
Wednesday Mar 16, 2016 at 11:34 GMT
Originally opened as https://github.com/artoolkit/jsartoolkit5/issues/17
Now that Chrome and Firefox start shipping WebAssembly support, it might be a sweet thing to look into https://github.com/WebAssembly/binaryen, to squeeze out a bit more perf.
The text was updated successfully, but these errors were encountered: