Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove from empty indexes #417

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Conversation

olenagerasimova
Copy link
Member

Closes #415
Corrected RpmMetadata.Remove() to work with empty indexes properly.

@olenagerasimova olenagerasimova requested review from a team and g4s8 and removed request for a team June 1, 2021 15:02
@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #417 (ca3f06f) into master (533e9f4) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #417      +/-   ##
============================================
- Coverage     84.22%   84.20%   -0.03%     
  Complexity      305      305              
============================================
  Files            56       56              
  Lines          1864     1861       -3     
  Branches        103      103              
============================================
- Hits           1570     1567       -3     
  Misses          276      276              
  Partials         18       18              
Impacted Files Coverage Δ
...main/java/com/artipie/rpm/meta/XmlPrimaryMaid.java 91.07% <100.00%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 533e9f4...ca3f06f. Read the comment docs.

@g4s8 g4s8 self-assigned this Jun 2, 2021
@g4s8 g4s8 added the ci/passed CI pipeline passed successfully label Jun 2, 2021
@g4s8 g4s8 assigned g4s8 and unassigned g4s8 Jun 2, 2021
@g4s8 g4s8 added the review label Jun 2, 2021
@g4s8 g4s8 enabled auto-merge (squash) June 2, 2021 07:14
Copy link
Member

@g4s8 g4s8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@g4s8 g4s8 merged commit 8ef1601 into artipie:master Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/passed CI pipeline passed successfully review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty index xml input stream
2 participants