refactor(backend)!: remove emissao de NFS-e (retem dados fiscais e fee) - #324
Merged
Conversation
…e EmitirNfsePayload
…os/erros) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…oAprovacao Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Coverage Report for frontend
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
10 tasks
arthuurw
added a commit
that referenced
this pull request
Jul 9, 2026
Restaura acesso pelo nav à página retida /treinador/dados-fiscais após a remoção das telas de nota fiscal (#324); espelha o item que existia para Notas fiscais. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
arthuurw
added a commit
that referenced
this pull request
Jul 9, 2026
Adiciona categoria PII de dados fiscais do treinador e a seção de retenção fiscal (~5a, art. 7º II / art. 16 I) — a coleta é retida após a remoção da emissão de NFS-e (#324). Emissor terceiro não é subprocessador ativo (handoff futuro); nota registrada em specification-lgpd. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
arthuurw
added a commit
that referenced
this pull request
Aug 6, 2026
Endpoint /internal/reconciliar-nfse, /internal/gerar-nfse-comissao e os workflows reconciliar-nfse.yml/gerar-nfse-comissao.yml foram removidos em 396fbb5 (#324) mas o README nao foi atualizado, causando 3 issues de falha de cron orfas (#326 #334 #335) apontando pra workflow inexistente. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remoção da emissão de NFS-e (AD-006)
A emissão de NFS-e passa a ser feita por software fiscal terceiro. Toda a emissão/documento fiscal sai do sistema — elimina código morto e a superfície de cert A1/mTLS no backend, antes do go-live de produção (
forzion_pnasce sem a tabela fiscal).Removido
NotaFiscal,NotaFiscalStatus,TipoNotaFiscal, eventosNotaFiscal*,NotaFiscalErrors, membro enumTipoAcaoAprovacao.ReprocessamentoNotaFiscal(sem renumerar os demais).Nfse/**+Admin/NotasFiscais/**,IEmissorNfseService,INotaFiscalRepository,ComissaoTreinadorPeriodo, queryListarComissaoPorTreinadorNoPeriodoAsync, payloads de outbox.EmissorNfseNacionalService,NullEmissorNfseService,NfseSettings,NfseMtlsCertificate,NotaFiscalRepository/config EF/DbSet, handlers de emissão/cancelamento/e-mail de nota + templates, registrations de DI./treinador/notas-fiscais+/admin/notas-fiscais, nav, chamadas de nota emnfse.ts(split), tipos OpenAPI/e2e/README.gerar-nfse-comissao.yml+reconciliar-nfse.yml.RemoverNotasFiscais: dropa sónotas_fiscais.Retido (guarda contra regressão)
DadosFiscais/EnderecoFiscalVO, colunasdados_fiscais_*, endpoints/dados-fiscais+/cep, form/banner/validações,TipoAcaoAprovacao.DefinicaoDadosFiscaisTreinador.ApplicationFeeAmount(Stripe destination charge) — intacto.PagamentoTreinador*+ fluxo de estorno/disputa (só o subscriber fiscal saiu).Verificação
forzion.tech.slnx0 err/0 warn;dotnet formatclean; unit não-Docker verde; frontend vitest verde..specs/features/remocao-emissao-nfse/validation.md.specification-fiscalarquivada; emissão removida de db/observability/security/lgpd/frontend/infrastructure/performance/concurrency/stripe; contagens re-ancoradas.developjá nivelado a homolog em separado.Deferido ao CI (Docker down local)
Endpoints de nota → 404 (WebApplicationFactory), migration apply (Testcontainers), E2E backend, e2e frontend. Validam neste PR.