Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some improvements #16

Merged
merged 11 commits into from
Mar 10, 2022
Merged

Some improvements #16

merged 11 commits into from
Mar 10, 2022

Conversation

fewensa
Copy link
Collaborator

@fewensa fewensa commented Mar 4, 2022 •
edited
Loading

fewensa and others added 9 commits October 14, 2021 19:08
@fewensa @vyneer @ibraheemdev
Fix error and Improvements struct (#1)
28499d7 
* Fixed failing compilation with `serde::export`

* Make the "use" part nicer

thanks @ibraheemdev <3

Co-authored-by: Ibraheem Ahmed <[email protected]>

* Change endpoint types to String, Remove lifetime

Co-authored-by: vyneer <[email protected]>
Co-authored-by: vyneer <[email protected]>
Co-authored-by: Ibraheem Ahmed <[email protected]>
@fewensa
Add timeout when create client (#2)
f8ae467
@fewensa
Derive Clone and Debug (#3)
f52df8b
@fewensa
Fix unwrap (#4)
1483848 
* Add unwrap api

* Remove unwrap
@fewensa
Helpful error message
a65cfd5
@fewensa
Use serde_json and helpful error message
02335af
@fewensa
Helpful error (#5)
8e905eb 
* Helpful error message

* Use serde_json and helpful error message
@fewensa
Fix test
820212d
@fewensa
Merge branch 'helpful-error'
d39a292
@arthurkhlghatyan
Copy link
Owner

Hey, thanks for PR @fewensa seems wasm-support is failing, do you think we could figure something out for this?

@fewensa
Copy link
Collaborator Author

fewensa commented Mar 10, 2022

Let's me check it late

fewensa and others added 2 commits March 10, 2022 15:46
@fewensa
Wasm support (#6)
0b56391 
* Clippy

* Fix wasm build
@fewensa
Format
2731794
@fewensa
Copy link
Collaborator Author

fewensa commented Mar 10, 2022 •
edited
Loading

It's fixed. but now the request can not support set timeout in wasm mode. seanmonstar/reqwest#288 seanmonstar/reqwest#1135

@arthurkhlghatyan arthurkhlghatyan merged commit 220c345 into arthurkhlghatyan:master Mar 10, 2022
@arthurkhlghatyan
Copy link
Owner

Yeah, thanks man, approved will deploy a new version in a moment

@fewensa
Copy link
Collaborator Author

fewensa commented Mar 11, 2022

Hi, You published in crate.io (1.0.3) it seems not from master branch?
https://docs.rs/crate/gql_client/1.0.3/source/src/client.rs

@arthurkhlghatyan
Copy link
Owner

Hey just published 1.0.4 from master https://crates.io/crates/gql_client/1.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthurkhlghatyan arthurkhlghatyan arthurkhlghatyan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fewensa @arthurkhlghatyan