Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move diagnostic calculation outside of the critical section #47

Closed
artempyanykh opened this issue Aug 18, 2022 · 0 comments · Fixed by #50
Closed

Move diagnostic calculation outside of the critical section #47

artempyanykh opened this issue Aug 18, 2022 · 0 comments · Fixed by #50

Comments

@artempyanykh
Copy link
Owner

Right now, diagnostic calculation is added as a hook and happens inside a critical section: https://github.com/artempyanykh/marksman/blob/main/Marksman/Server.fs#L216; only the actual public of the updated diagnostic happens asynchronously. This means that diagnostic recalculation happens on every keystroke/state_update which is not cool and can lead to timeouts (albeit only on really huge workspaces with hundreds or thousands of md files).

The good news that it should be pretty easy to move diag recalc off of the critical section and make it happen async.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant