Sourcery refactored master branch #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| self.log.debug(f"serving finished") | ||
| self.log.debug('serving finished') |
There was a problem hiding this comment.
Function Client.download refactored with the following changes:
- Replace f-string with no interpolated values with string (
remove-redundant-fstring)
Comment on lines
-12
to
+18
| text = "T" | ||
| if not favicon_path.exists(): | ||
| W, H = (360, 360) | ||
| color = tuple((random.randint(0, 255) for _ in range(3))) | ||
| im = Image.new("RGB", (W, H), color) | ||
| draw = ImageDraw.Draw(im) | ||
| font = ImageFont.truetype("arial.ttf", 50) | ||
| text = "T" |
There was a problem hiding this comment.
Function FaviconIconView.faviconicon refactored with the following changes:
- Move assignments closer to their usage (
move-assign)
| kwargs.update({"search": search_query}) | ||
|
|
||
| kwargs["search"] = search_query |
There was a problem hiding this comment.
Function IndexView.index refactored with the following changes:
- Add single value to dictionary directly rather than using update() (
simplify-dictionary-update)
Comment on lines
-40
to
+50
| if message.reply_markup: | ||
| if isinstance(message.reply_markup, types.ReplyInlineMarkup): | ||
| reply_btns = [ | ||
| [ | ||
| {"url": button.url, "text": button.text} | ||
| for button in button_row.buttons | ||
| if isinstance(button, types.KeyboardButtonUrl) | ||
| ] | ||
| for button_row in message.reply_markup.rows | ||
| if message.reply_markup and isinstance( | ||
| message.reply_markup, types.ReplyInlineMarkup | ||
| ): | ||
| reply_btns = [ | ||
| [ | ||
| {"url": button.url, "text": button.text} | ||
| for button in button_row.buttons | ||
| if isinstance(button, types.KeyboardButtonUrl) | ||
| ] | ||
| for button_row in message.reply_markup.rows | ||
| ] |
There was a problem hiding this comment.
Function InfoView.info refactored with the following changes:
- Merge nested if conditions (
merge-nested-ifs) - Replace if statement with if expression (
assign-if-exp)
| pos = -1 if req.query.get("big", None) else int(len(photo.sizes) / 2) | ||
| pos = -1 if req.query.get("big", None) else len(photo.sizes) // 2 |
There was a problem hiding this comment.
Function LogoView.logo refactored with the following changes:
- Simplify division expressions. (
simplify-division)
Comment on lines
-60
to
+82
| if request.app["is_authenticated"] and str(request.rel_url.path) not in [ | ||
| if not request.app["is_authenticated"] or str(request.rel_url.path) in [ | ||
| "/login", | ||
| "/logout", | ||
| ]: | ||
| url = request.app.router["login_page"].url_for() | ||
| if str(request.rel_url) != "/": | ||
| url = url.with_query(redirect_to=str(request.rel_url)) | ||
| return await handler(request) | ||
| url = request.app.router["login_page"].url_for() | ||
| if str(request.rel_url) != "/": | ||
| url = url.with_query(redirect_to=str(request.rel_url)) | ||
|
|
||
| basic_auth_check_resp = _do_basic_auth_check(request) | ||
| basic_auth_check_resp = _do_basic_auth_check(request) | ||
|
|
||
| if basic_auth_check_resp is True: | ||
| return await handler(request) | ||
| if basic_auth_check_resp is True: | ||
| return await handler(request) | ||
|
|
||
| cookies_auth_check_resp = await _do_cookies_auth_check(request) | ||
| cookies_auth_check_resp = await _do_cookies_auth_check(request) | ||
|
|
||
| if cookies_auth_check_resp is not None: | ||
| return await handler(request) | ||
| if cookies_auth_check_resp is not None: | ||
| return await handler(request) | ||
|
|
||
| if isinstance(basic_auth_check_resp, Response): | ||
| return basic_auth_check_resp | ||
| if isinstance(basic_auth_check_resp, Response): | ||
| return basic_auth_check_resp | ||
|
|
||
| return HTTPFound(url) | ||
|
|
||
| return await handler(request) | ||
| return HTTPFound(url) |
There was a problem hiding this comment.
Function middleware_factory.factory refactored with the following changes:
- Add guard clause (
last-if-guard)
Comment on lines
-42
to
+48
| color = tuple([random.randint(0, 255) for i in range(3)]) | ||
| color = tuple(random.randint(0, 255) for _ in range(3)) | ||
| im = Image.new("RGB", (100, 100), color) | ||
| temp = io.BytesIO() | ||
| im.save(temp, "PNG") | ||
| body = temp.getvalue() | ||
| else: | ||
| thumb_pos = int(len(thumbnails) / 2) | ||
| thumb_pos = len(thumbnails) // 2 |
There was a problem hiding this comment.
Function ThumbnailView.thumbnail_get refactored with the following changes:
- Replace unneeded comprehension with generator (
comprehension-to-generator) - Replace unused for index with underscore (
for-index-underscore) - Simplify division expressions. (
simplify-division)
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 2.11%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!