-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(lens): add reviewed reactive change test #973
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Despite that, I'll be trying to work on a solution for making the test using match(true) work |
@caio2983 thank you for your engagement! The original test code is correct, it shows the problem that "compAtom" is not updated when the passed dependencies are changed, we need to fix exactly this.
|
Hello @artalar , I think I managed to fix the issue in my latest commit fix(lens): add reactive functionality in match . The tests now pass . Please let me know if any changes need to be made |
All great, thanks a lot! |
fix #970
Hello @artalar ,
The test wasn't passing because of the usage of
match(true)
. Thematch
function was fixed with atrue
literal value , meaning thatcompAtom
was non-reactive to the changes ofboolAtom
.In the new test,
match(boolAtom)
was used instead, makingmatch
reactive to changes ofboolAtom