Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(lens): add reviewed reactive change test #973

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

caio2983
Copy link
Contributor

@caio2983 caio2983 commented Nov 9, 2024

fix #970
Hello @artalar ,

The test wasn't passing because of the usage of match(true) . The match function was fixed with a true literal value , meaning that compAtom was non-reactive to the changes of boolAtom .

In the new test, match(boolAtom) was used instead, making match reactive to changes of boolAtom

Copy link

stackblitz bot commented Nov 9, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

vercel bot commented Nov 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
reatom ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 2:52pm

@caio2983
Copy link
Contributor Author

caio2983 commented Nov 9, 2024

Hello @artalar ,

The test wasn't passing because of the usage of match(true) . The match function was fixed with a true literal value , meaning that compAtom was non-reactive to the changes of boolAtom .

In the new test, match(boolAtom) was used instead, making match reactive to changes of boolAtom

Despite that, I'll be trying to work on a solution for making the test using match(true) work

@artalar
Copy link
Owner

artalar commented Nov 11, 2024

@caio2983 thank you for your engagement! The original test code is correct, it shows the problem that "compAtom" is not updated when the passed dependencies are changed, we need to fix exactly this.

Despite that, I'll be trying to work on a solution for making the test using match(true) work
Nice!

@caio2983
Copy link
Contributor Author

Hello @artalar ,

I think I managed to fix the issue in my latest commit fix(lens): add reactive functionality in match . The tests now pass .

Please let me know if any changes need to be made

@artalar artalar merged commit 659b78d into artalar:v3 Nov 14, 2024
2 of 3 checks passed
@artalar
Copy link
Owner

artalar commented Nov 14, 2024

All great, thanks a lot!

@github-actions github-actions bot mentioned this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reatom/lens match reactive broken
2 participants