AROR-1403 add rails 5 support #1
Conversation
nakedsushi
force-pushed
the
schallereqo/rails-5
branch
from
ee05a85
to
ce6279a
Compare
|
Sorry to open this PR again, but I guess that's what I get for making the changes in this branch. This is to make ihasa ruby 2.7.1 compatable (https://art19co.atlassian.net/browse/PLAT-425) @ziggythehamster you want to give this PR a look before I make a new PR against upstream? I've already brought art19's master up to date with upstream (it was one commit off). |
.travis.yml
Outdated
| language: ruby | ||
| cache: bundler | ||
| rvm: | ||
| - 2.7.1 |
There was a problem hiding this comment.
| - 2.7.1 | |
| - 2.7 |
We probably don't need to specify the version number so strictly
.travis.yml
Outdated
| - 2.7.1 | ||
| - 2.6 | ||
| - 2.5 | ||
| - 2.4 |
There was a problem hiding this comment.
| - 2.4 | |
| - 2.4 | |
| - jruby | |
| - truffleruby |
If the suite passes, why not?
|
Not really sure why I'm getting these notifications, but good job you guys!
…On Thu, May 7, 2020, 5:00 PM Keith Gable ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In .travis.yml
<#1 (comment)>:
> @@ -1,3 +1,16 @@
+language: ruby
+cache: bundler
+rvm:
+ - 2.7.1
⬇️ Suggested change
- - 2.7.1
+ - 2.7
We probably don't need to specify the version number so strictly
------------------------------
In .travis.yml
<#1 (comment)>:
> @@ -1,3 +1,16 @@
+language: ruby
+cache: bundler
+rvm:
+ - 2.7.1
+ - 2.6
+ - 2.5
+ - 2.4
⬇️ Suggested change
- - 2.4
+ - 2.4
+ - jruby
+ - truffleruby
If the suite passes, why not?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (review)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHFAFHZVSYJ2EEXQAV42ATRQMOPZANCNFSM4E2HVF5Q>
.
|
|
@schallereqo It's your PR from 2018, but I guess we forgot to make an upstream PR, so now we're doing that plus ensuring that it works under Ruby 2.7 (+ maybe TruffleRuby and JRuby). If upstream ends up not accepting the change (could be abandoned), we'll begin maintaining a separate fork with a different name with packages on GitHub Packages because the current way of using Git URLs is not very efficient (a few KBs vs. a few MBs, imprecise artifacts). Hopefully they accept our changes and we can destroy our fork, but there are a few of these where the upstream maintainer is now MIA and our fork has some minor added functionality (e.g., art19/broadcast_calendar where you added week support) that won't ever get merged. |
|
I moved my changes that were reverted out of here to lyang/PLAT-425 branch so that I don't clobber some git refs again. |
No description provided.