-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby 3 upgrades #1
Conversation
|
||
s.add_runtime_dependency 'activemodel', '>= 4.0' | ||
s.add_runtime_dependency 'bigdecimal', '~> 3.0' | ||
s.add_runtime_dependency 'cassandra-driver', '~> 3.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once Jeremy's fork is published we can confirm that we pull in the fork that Jeremy is setting up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do
Either in this PR or a follow up, could you add publishing instructions, a rake task and an ART19 revision to the version number: https://github.com/art19/jsonapi.rb/pull/5/files |
7438957
to
29c5b32
Compare
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Getting together necessary changes to upgrade this fork to be compatible with Ruby3.
Commits are pulled from https://github.com/tatethurston/cequel/pull/1/files
Resolves https://jira.music.amazon.dev/browse/ART19PLAT-249