Ruby 3 upgrades #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatethurston
reviewed
Jul 2, 2024
tatethurston
reviewed
Jul 2, 2024
tatethurston
reviewed
Jul 2, 2024
tatethurston
reviewed
Jul 2, 2024
|
|
||
| s.add_runtime_dependency 'activemodel', '>= 4.0' | ||
| s.add_runtime_dependency 'bigdecimal', '~> 3.0' | ||
| s.add_runtime_dependency 'cassandra-driver', '~> 3.0' |
There was a problem hiding this comment.
Once Jeremy's fork is published we can confirm that we pull in the fork that Jeremy is setting up
tatethurston
approved these changes
Jul 2, 2024
|
Either in this PR or a follow up, could you add publishing instructions, a rake task and an ART19 revision to the version number: https://github.com/art19/jsonapi.rb/pull/5/files |
lexahu
force-pushed
the
lexahu/ruby3-upgrades
branch
from
7438957
to
29c5b32
Compare
tatethurston
reviewed
Jul 2, 2024
tatethurston
reviewed
Jul 2, 2024
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting together necessary changes to upgrade this fork to be compatible with Ruby3.
Commits are pulled from https://github.com/tatethurston/cequel/pull/1/files
Resolves https://jira.music.amazon.dev/browse/ART19PLAT-249