Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3 upgrades #1

Merged
merged 9 commits into from
Jul 2, 2024
Merged

Ruby 3 upgrades #1

merged 9 commits into from
Jul 2, 2024

Conversation

lexahu
Copy link

@lexahu lexahu commented Jul 2, 2024

Getting together necessary changes to upgrade this fork to be compatible with Ruby3.

Commits are pulled from https://github.com/tatethurston/cequel/pull/1/files

Resolves https://jira.music.amazon.dev/browse/ART19PLAT-249


s.add_runtime_dependency 'activemodel', '>= 4.0'
s.add_runtime_dependency 'bigdecimal', '~> 3.0'
s.add_runtime_dependency 'cassandra-driver', '~> 3.0'
Copy link

@tatethurston tatethurston Jul 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once Jeremy's fork is published we can confirm that we pull in the fork that Jeremy is setting up

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

@tatethurston
Copy link

tatethurston commented Jul 2, 2024

Either in this PR or a follow up, could you add publishing instructions, a rake task and an ART19 revision to the version number: https://github.com/art19/jsonapi.rb/pull/5/files

Rakefile Outdated Show resolved Hide resolved
Rakefile Outdated Show resolved Hide resolved
@tatethurston
Copy link

LGTM

Copy link

@rortian rortian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tatthurs tatthurs merged commit 7645b7b into master Jul 2, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants