Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image comparison features to details dialog #683

Merged
merged 70 commits into from
Oct 28, 2020
Merged
Changes from 1 commit
Commits
Show all changes
70 commits
Select commit Hold shift + click to select a range
9b48e18
add zoom and swap buttons to details dialog
glubsy May 1, 2020
f42df12
attempt at double click on Qlabel
glubsy May 2, 2020
468a736
add normal size button
glubsy May 2, 2020
ea61976
drag mouse with ImageViewer class
glubsy May 2, 2020
02bd822
working zoom functions, mouse wheel event
glubsy Jun 4, 2020
c616291
working synchronized panning
glubsy Jun 4, 2020
a29f3fb
only update delta when mouse is being dragged to reduce paint events
glubsy Jun 4, 2020
60ddb9b
Working synchronized views.
glubsy Jun 5, 2020
c379791
Controller class to decouple from the dialog class
glubsy Jun 9, 2020
8103cb3
Disable unused methods from controller
glubsy Jun 10, 2020
b7abcf2
Use native QPixmap swap() method instead of manual setPixmap()
glubsy Jun 10, 2020
a706d0e
Implement mostly working ScrollArea viewer
glubsy Jun 16, 2020
970bb5e
Add mostly working ScrollArea imge viewers
glubsy Jun 20, 2020
aa79b31
Work around resizing down offset by 1 pixel.
glubsy Jun 21, 2020
977c20f
Add QSplitter to hide TableView in DetailsDialog
glubsy Jun 22, 2020
011939f
Keep scale accross files of the same dupe group.
glubsy Jun 23, 2020
9f15139
Fix view resetting when selecting reference only.
glubsy Jun 24, 2020
370b582
Add working zoom functions to GraphicsView viewers.
glubsy Jun 28, 2020
36ab844
Move buttons into the toolbar class.
glubsy Jun 28, 2020
e7b3252
Cleanup of details table
glubsy Jun 29, 2020
4ee9479
Add image comparison features to details dialog
glubsy Jul 2, 2020
b0a256f
Fix flake8 minor issues
glubsy Jul 2, 2020
7ab2998
Merge commit 'b0a256f0'
glubsy Jul 12, 2020
56912a7
Make details dialog dockable
glubsy Jul 13, 2020
3eddeb6
Fix ME/SE details dialogs, add preferences
glubsy Jul 14, 2020
95b8406
Fix scrollbar displayed while splitter maxed out
glubsy Jul 15, 2020
58c675d
Add custom icons
glubsy Jul 15, 2020
66127d0
Add credit for icons used, upscale exchange icon
glubsy Jul 15, 2020
85d6e05
Merge branch 'dockable_windows' into details_dialog_improvements_dev
glubsy Jul 15, 2020
3c816b2
Fix computing and setting offset to 0 for tableview
glubsy Jul 15, 2020
75621cc
Prevent Windows from floating if no decoration
glubsy Jul 15, 2020
9168d72
Update preferences on show(), not in constructor
glubsy Jul 15, 2020
733b3b0
Prevent zoom for images of differing dimensions
glubsy Jul 15, 2020
ac94103
Fix resize of top frame not updating scaled pixmap
glubsy Jul 16, 2020
6213d50
Squashed commit of the following:
glubsy Jul 16, 2020
3539263
Add tabs to preference dialog.
glubsy Jul 20, 2020
298f659
Fix Restore Default Preferences button
glubsy Jul 20, 2020
cf64565
Add option to use internal icons in details dialog
glubsy Jul 21, 2020
9ae0d7e
Add color picker buttons to preferences dialog
glubsy Jul 22, 2020
730fadf
Merge branch 'preferences_tabs' into details_dialog_improvements
glubsy Jul 22, 2020
7dc9f25
Merge branch 'master' into details_dialog_improvements
glubsy Jul 29, 2020
1823575
Fix swapping table view columns
glubsy Jul 29, 2020
1937120
Fix toggling details view via menu or shortcut
glubsy Jul 29, 2020
9795f14
Fix title bar toggling on/off when dialog
glubsy Jul 29, 2020
da8c493
Toggle visibility of details dialog
glubsy Jul 29, 2020
eab5003
Add color preference for delta in details table
glubsy Jul 29, 2020
fa54e93
Add preference to turn off scrollbars in viewers
glubsy Jul 30, 2020
79613f9
Fix crash quitting while details dialog active
glubsy Jul 30, 2020
9b8637f
Stretch last header section in Result window
glubsy Jul 30, 2020
7e4f371
Avoid crash when quitting
glubsy Jul 30, 2020
2364281
Remove unused properties in details table headers
glubsy Jul 30, 2020
1125438
Save dock panel position on quit
glubsy Jul 30, 2020
2620d00
Fix layout error
glubsy Jul 31, 2020
d2cdcc9
Fix 1 pixel sized color in color picker buttons
glubsy Aug 1, 2020
acdeb01
Tweak preference layout for better readability
glubsy Aug 1, 2020
628d772
Use FormLayout instead of GridLayout
glubsy Aug 1, 2020
3be1ee8
Merge branch 'master' into details_dialog_improvements
glubsy Aug 1, 2020
056fa81
Revert stretching last section in Result window
glubsy Aug 1, 2020
a3e402a
Group general interface options together
glubsy Aug 1, 2020
de5e612
Add stretch to bottom of General pref tab
glubsy Aug 1, 2020
fbd7c4f
Tweak visuals for cache selection item
glubsy Aug 1, 2020
0104d89
Fix alignment for combo box's label
glubsy Aug 1, 2020
866bf99
Prevent Directories tab from closing on MacOS
glubsy Aug 1, 2020
76fbfc2
Fix adding new Result tab if already existed
glubsy Aug 2, 2020
089f00a
Fix typo in class member reference
glubsy Aug 3, 2020
b8af2a4
Don't show parent window's context menu on viewers
glubsy Sep 2, 2020
a265b71
Improve comment reflecting modification of function
glubsy Oct 28, 2020
92feba5
Remove obsolete UI setup code
glubsy Oct 28, 2020
59ce740
Remove print debug statements
glubsy Oct 28, 2020
cf5ba03
Remove icon credits from about box
glubsy Oct 28, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Avoid crash when quitting
* If details dialog failed to be created for some reason, avoid crashing by dereferencing a null pointer
glubsy committed Jul 30, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 7e4f37184124be483b3d6846aadfb24da7e758a1
3 changes: 2 additions & 1 deletion qt/app.py
Original file line number Diff line number Diff line change
@@ -248,7 +248,8 @@ def preferencesTriggered(self):
preferences_dialog.setParent(None)

def quitTriggered(self):
self.details_dialog.close()
if self.details_dialog is not None:
self.details_dialog.close()
self.directories_dialog.close()

def showAboutBoxTriggered(self):