Support 0.19! #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Elm Version! 🎉 Elm made some changes to the history format -- wrapping the whole thing in an Elm data structure (necessary as Elm now handles the history interface) and changing
ctorto$,_0toa,_1tob, etc. Relatively minor changes were needed in ElmRings to support this.Due to an apparent issue with elm-compiler it was hard to get the example working in 0.19. Ultimately I've packaged up a copy of @rtfeldman's Elm SPA example temporarily to show that ElmRings does, indeed, work with 0.19.