forked from MoonshotAI/kimi-code
-
Notifications
You must be signed in to change notification settings - Fork 0
fix(tui): surface the compaction model (slash command + started indicator) #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@moonshot-ai/kimi-code": minor | ||
| --- | ||
|
|
||
| Surface the dedicated compaction model in the TUI: add a `/compaction-model` slash command that picks and persists `[compaction_model]` (mirroring `/visual-model`), and show which model performs compaction — the in-progress indicator now reads "Compacting context using <model>..." for manual and automatic compaction, in the terminal TUI, the ACP adapter, and the VS Code extension. The `compaction.started` event carries `model` and `model_display`, and `/visual-model`, `/substitute-model`, and `/compaction-model` now read their configured value back on the v2 engine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,259 @@ | ||
| --- | ||
| name: "speckit-analyze" | ||
| description: "Perform a non-destructive cross-artifact consistency and quality analysis across spec.md, plan.md, and tasks.md after task generation." | ||
| compatibility: "Requires spec-kit project structure with .specify/ directory" | ||
| metadata: | ||
| author: "github-spec-kit" | ||
| source: "templates/commands/analyze.md" | ||
| --- | ||
|
|
||
|
|
||
| ## User Input | ||
|
|
||
| ```text | ||
| $ARGUMENTS | ||
| ``` | ||
|
|
||
| You **MUST** consider the user input before proceeding (if not empty). | ||
|
|
||
| ## Pre-Execution Checks | ||
|
|
||
| **Check for extension hooks (before analysis)**: | ||
| - Check if `.specify/extensions.yml` exists in the project root. | ||
| - If it exists, read it and look for entries under the `hooks.before_analyze` key | ||
| - If the YAML cannot be parsed or is invalid, skip hook checking silently and continue normally | ||
| - Filter out hooks where `enabled` is explicitly `false`. Treat hooks without an `enabled` field as enabled by default. | ||
| - For each remaining hook, do **not** attempt to interpret or evaluate hook `condition` expressions: | ||
| - If the hook has no `condition` field, or it is null/empty, treat the hook as executable | ||
| - If the hook defines a non-empty `condition`, skip the hook and leave condition evaluation to the HookExecutor implementation | ||
| - When constructing command invocations from hook command names, replace dots (`.`) with hyphens (`-`). For example, `speckit.git.commit` → `/skill:speckit-git-commit`. | ||
| - For each executable hook, output the following based on its `optional` flag: | ||
| - **Optional hook** (`optional: true`): | ||
| ``` | ||
| ## Extension Hooks | ||
|
|
||
| **Optional Pre-Hook**: {extension} | ||
| Command: `/{command}` | ||
| Description: {description} | ||
|
|
||
| Prompt: {prompt} | ||
| To execute: `/{command}` | ||
| ``` | ||
| - **Mandatory hook** (`optional: false`): | ||
| ``` | ||
| ## Extension Hooks | ||
|
|
||
| **Automatic Pre-Hook**: {extension} | ||
| Executing: `/{command}` | ||
| EXECUTE_COMMAND: {command} | ||
|
|
||
| Wait for the result of the hook command before proceeding to the Goal. | ||
| ``` | ||
| After emitting the block above you MUST actually invoke the hook and wait for it to finish before continuing. Run it the same way you would run the command yourself in this agent/session (the invocation may differ from the literal `{command}` id shown above, e.g. a skills-mode agent runs it as `/skill:speckit-...` or `$speckit-...`). Emitting the block alone does not run the hook. | ||
| - If no hooks are registered or `.specify/extensions.yml` does not exist, skip silently | ||
|
|
||
| ## Goal | ||
|
|
||
| Identify inconsistencies, duplications, ambiguities, and underspecified items across the three core artifacts (`spec.md`, `plan.md`, `tasks.md`) before implementation. This command MUST run only after `/skill:speckit-tasks` has successfully produced a complete `tasks.md`. | ||
|
|
||
| ## Operating Constraints | ||
|
|
||
| **STRICTLY READ-ONLY**: Do **not** modify any files. Output a structured analysis report. Offer an optional remediation plan (user must explicitly approve before any follow-up editing commands would be invoked manually). | ||
|
|
||
| **Constitution Authority**: The project constitution (`.specify/memory/constitution.md`) is **non-negotiable** within this analysis scope. Constitution conflicts are automatically CRITICAL and require adjustment of the spec, plan, or tasks—not dilution, reinterpretation, or silent ignoring of the principle. If a principle itself needs to change, that must occur in a separate, explicit constitution update outside `/skill:speckit-analyze`. | ||
|
|
||
| ## Execution Steps | ||
|
|
||
| ### 1. Initialize Analysis Context | ||
|
|
||
| Run `.specify/scripts/bash/check-prerequisites.sh --json --require-tasks --include-tasks` once from repo root and parse JSON for FEATURE_DIR and AVAILABLE_DOCS. Derive absolute paths: | ||
|
|
||
| - SPEC = FEATURE_DIR/spec.md | ||
| - PLAN = FEATURE_DIR/plan.md | ||
| - TASKS = FEATURE_DIR/tasks.md | ||
|
|
||
| Abort with an error message if any required file is missing (instruct the user to run missing prerequisite command). | ||
| For single quotes in args like "I'm Groot", use escape syntax: e.g 'I'\''m Groot' (or double-quote if possible: "I'm Groot"). | ||
|
|
||
| ### 2. Load Artifacts (Progressive Disclosure) | ||
|
|
||
| Load only the minimal necessary context from each artifact: | ||
|
|
||
| **From spec.md:** | ||
|
|
||
| - Overview/Context | ||
| - Functional Requirements | ||
| - Success Criteria (measurable outcomes — e.g., performance, security, availability, user success, business impact) | ||
| - User Stories | ||
| - Edge Cases (if present) | ||
|
|
||
| **From plan.md:** | ||
|
|
||
| - Architecture/stack choices | ||
| - Data Model references | ||
| - Phases | ||
| - Technical constraints | ||
|
|
||
| **From tasks.md:** | ||
|
|
||
| - Task IDs | ||
| - Descriptions | ||
| - Phase grouping | ||
| - Parallel markers [P] | ||
| - Referenced file paths | ||
|
|
||
| **From constitution:** | ||
|
|
||
| - Load `.specify/memory/constitution.md` for principle validation | ||
|
|
||
| ### 3. Build Semantic Models | ||
|
|
||
| Create internal representations (do not include raw artifacts in output): | ||
|
|
||
| - **Requirements inventory**: For each Functional Requirement (FR-###) and Success Criterion (SC-###), record a stable key. Use the explicit FR-/SC- identifier as the primary key when present, and optionally also derive an imperative-phrase slug for readability (e.g., "User can upload file" → `user-can-upload-file`). Include only Success Criteria items that require buildable work (e.g., load-testing infrastructure, security audit tooling), and exclude post-launch outcome metrics and business KPIs (e.g., "Reduce support tickets by 50%"). | ||
| - **User story/action inventory**: Discrete user actions with acceptance criteria | ||
| - **Task coverage mapping**: Map each task to one or more requirements or stories (inference by keyword / explicit reference patterns like IDs or key phrases) | ||
| - **Constitution rule set**: Extract principle names and MUST/SHOULD normative statements | ||
|
|
||
| ### 4. Detection Passes (Token-Efficient Analysis) | ||
|
|
||
| Focus on high-signal findings. Limit to 50 findings total; aggregate remainder in overflow summary. | ||
|
|
||
| #### A. Duplication Detection | ||
|
|
||
| - Identify near-duplicate requirements | ||
| - Mark lower-quality phrasing for consolidation | ||
|
|
||
| #### B. Ambiguity Detection | ||
|
|
||
| - Flag vague adjectives (fast, scalable, secure, intuitive, robust) lacking measurable criteria | ||
| - Flag unresolved placeholders (TODO, TKTK, ???, `<placeholder>`, etc.) | ||
|
|
||
| #### C. Underspecification | ||
|
|
||
| - Requirements with verbs but missing object or measurable outcome | ||
| - User stories missing acceptance criteria alignment | ||
| - Tasks referencing files or components not defined in spec/plan | ||
|
|
||
| #### D. Constitution Alignment | ||
|
|
||
| - Any requirement or plan element conflicting with a MUST principle | ||
| - Missing mandated sections or quality gates from constitution | ||
|
|
||
| #### E. Coverage Gaps | ||
|
|
||
| - Requirements with zero associated tasks | ||
| - Tasks with no mapped requirement/story | ||
| - Success Criteria requiring buildable work (performance, security, availability) not reflected in tasks | ||
|
|
||
| #### F. Inconsistency | ||
|
|
||
| - Terminology drift (same concept named differently across files) | ||
| - Data entities referenced in plan but absent in spec (or vice versa) | ||
| - Task ordering contradictions (e.g., integration tasks before foundational setup tasks without dependency note) | ||
| - Conflicting requirements (e.g., one requires Next.js while other specifies Vue) | ||
|
|
||
| ### 5. Severity Assignment | ||
|
|
||
| Use this heuristic to prioritize findings: | ||
|
|
||
| - **CRITICAL**: Violates constitution MUST, missing core spec artifact, or requirement with zero coverage that blocks baseline functionality | ||
| - **HIGH**: Duplicate or conflicting requirement, ambiguous security/performance attribute, untestable acceptance criterion | ||
| - **MEDIUM**: Terminology drift, missing non-functional task coverage, underspecified edge case | ||
| - **LOW**: Style/wording improvements, minor redundancy not affecting execution order | ||
|
|
||
| ### 6. Produce Compact Analysis Report | ||
|
|
||
| Output a Markdown report (no file writes) with the following structure: | ||
|
|
||
| ## Specification Analysis Report | ||
|
|
||
| | ID | Category | Severity | Location(s) | Summary | Recommendation | | ||
| |----|----------|----------|-------------|---------|----------------| | ||
| | A1 | Duplication | HIGH | spec.md:L120-134 | Two similar requirements ... | Merge phrasing; keep clearer version | | ||
|
|
||
| (Add one row per finding; generate stable IDs prefixed by category initial.) | ||
|
|
||
| **Coverage Summary Table:** | ||
|
|
||
| | Requirement Key | Has Task? | Task IDs | Notes | | ||
| |-----------------|-----------|----------|-------| | ||
|
|
||
| **Constitution Alignment Issues:** (if any) | ||
|
|
||
| **Unmapped Tasks:** (if any) | ||
|
|
||
| **Metrics:** | ||
|
|
||
| - Total Requirements | ||
| - Total Tasks | ||
| - Coverage % (requirements with >=1 task) | ||
| - Ambiguity Count | ||
| - Duplication Count | ||
| - Critical Issues Count | ||
|
|
||
| ### 7. Provide Next Actions | ||
|
|
||
| At end of report, output a concise Next Actions block: | ||
|
|
||
| - If CRITICAL issues exist: Recommend resolving before `/skill:speckit-implement` | ||
| - If only LOW/MEDIUM: User may proceed, but provide improvement suggestions | ||
| - Provide explicit command suggestions: e.g., "Run /skill:speckit-specify with refinement", "Run /skill:speckit-plan to adjust architecture", "Manually edit tasks.md to add coverage for 'performance-metrics'" | ||
|
|
||
| ### 8. Offer Remediation | ||
|
|
||
| Ask the user: "Would you like me to suggest concrete remediation edits for the top N issues?" (Do NOT apply them automatically.) | ||
|
|
||
| ### 9. Check for extension hooks | ||
|
|
||
| After reporting, check if `.specify/extensions.yml` exists in the project root. | ||
| - If it exists, read it and look for entries under the `hooks.after_analyze` key | ||
| - If the YAML cannot be parsed or is invalid, skip hook checking silently and continue normally | ||
| - Filter out hooks where `enabled` is explicitly `false`. Treat hooks without an `enabled` field as enabled by default. | ||
| - For each remaining hook, do **not** attempt to interpret or evaluate hook `condition` expressions: | ||
| - If the hook has no `condition` field, or it is null/empty, treat the hook as executable | ||
| - If the hook defines a non-empty `condition`, skip the hook and leave condition evaluation to the HookExecutor implementation | ||
| - When constructing command invocations from hook command names, replace dots (`.`) with hyphens (`-`). For example, `speckit.git.commit` → `/skill:speckit-git-commit`. | ||
| - For each executable hook, output the following based on its `optional` flag: | ||
| - **Optional hook** (`optional: true`): | ||
| ``` | ||
| ## Extension Hooks | ||
|
|
||
| **Optional Hook**: {extension} | ||
| Command: `/{command}` | ||
| Description: {description} | ||
|
|
||
| Prompt: {prompt} | ||
| To execute: `/{command}` | ||
| ``` | ||
| - **Mandatory hook** (`optional: false`): | ||
| ``` | ||
| ## Extension Hooks | ||
|
|
||
| **Automatic Hook**: {extension} | ||
| Executing: `/{command}` | ||
| EXECUTE_COMMAND: {command} | ||
| ``` | ||
| After emitting the block above you MUST actually invoke the hook and wait for it to finish before continuing. Run it the same way you would run the command yourself in this agent/session (the invocation may differ from the literal `{command}` id shown above, e.g. a skills-mode agent runs it as `/skill:speckit-...` or `$speckit-...`). Emitting the block alone does not run the hook. | ||
| - If no hooks are registered or `.specify/extensions.yml` does not exist, skip silently | ||
|
|
||
| ## Operating Principles | ||
|
|
||
| ### Context Efficiency | ||
|
|
||
| - **Minimal high-signal tokens**: Focus on actionable findings, not exhaustive documentation | ||
| - **Progressive disclosure**: Load artifacts incrementally; don't dump all content into analysis | ||
| - **Token-efficient output**: Limit findings table to 50 rows; summarize overflow | ||
| - **Deterministic results**: Rerunning without changes should produce consistent IDs and counts | ||
|
|
||
| ### Analysis Guidelines | ||
|
|
||
| - **NEVER modify files** (this is read-only analysis) | ||
| - **NEVER hallucinate missing sections** (if absent, report them accurately) | ||
| - **Prioritize constitution violations** (these are always CRITICAL) | ||
| - **Use examples over exhaustive rules** (cite specific instances, not generic patterns) | ||
| - **Report zero issues gracefully** (emit success report with coverage statistics) | ||
|
|
||
| ## Context | ||
|
|
||
| $ARGUMENTS | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../../.specify/extensions/bug/.specify-dev/agent-commands/kimi/speckit-bug-assess/SKILL.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../../.specify/extensions/bug/.specify-dev/agent-commands/kimi/speckit-bug-fetch/SKILL.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../../.specify/extensions/bug/.specify-dev/agent-commands/kimi/speckit-bug-fix/SKILL.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../../.specify/extensions/bug/.specify-dev/agent-commands/kimi/speckit-bug-issue/SKILL.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../../.specify/extensions/bug/.specify-dev/agent-commands/kimi/speckit-bug-pr/SKILL.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../../.specify/extensions/bug/.specify-dev/agent-commands/kimi/speckit-bug-test/SKILL.md |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🟠 Major | 🏗️ Heavy lift
🧩 Analysis chain
🏁 Script executed:
Repository: arrrrny/kimi-code-sync
Length of output: 15592
🏁 Script executed:
Repository: arrrrny/kimi-code-sync
Length of output: 50380
🏁 Script executed:
Repository: arrrrny/kimi-code-sync
Length of output: 50380
🏁 Script executed:
Repository: arrrrny/kimi-code-sync
Length of output: 50379
🏁 Script executed:
Repository: arrrrny/kimi-code-sync
Length of output: 50381
🌐 Web query:
Search for the.specify/extensions.ymlhooks.before_analyzeHookExecutorextension-hook specification and determine whether hookcommandvalues invoke shell commands directly or named skills.💡 Result:
The Spec Kit extension hook specification for
.specify/extensions.ymldefines hooks that execute at specific lifecycle events (such asbefore_analyze) [1][2][3]. Thecommandvalue specified within a hook configuration is not a direct invocation of a shell command named after a "skill" [3][4]. Instead, these command values function as identifiers for registered slash commands [5][3]. When the system (specifically theHookExecutor) processes these hooks, it constructs executable slash commands by transforming the command string—typically replacing dots (.) with hyphens (-) [6][7][8]. For example, a command value defined asspeckit.git.commitis invoked as the slash command/speckit-git-commit[6][7]. TheHookExecutoris responsible for resolving these hooks, determining their execution eligibility, and formatting the corresponding command messages [3][4][9].Citations:
🏁 Script executed:
Repository: arrrrny/kimi-code-sync
Length of output: 50380
🏁 Script executed:
Repository: arrrrny/kimi-code-sync
Length of output: 1851
🏁 Script executed:
Repository: arrrrny/kimi-code-sync
Length of output: 46304
🏁 Script executed:
Repository: arrrrny/kimi-code-sync
Length of output: 50378
Add a trust gate before mandatory extension-skill dispatch.
.specify/extensions.ymlselects slash-command identifiers, not shell commands, but each selected project Skill is rendered into an agent turn. A repository-controlled Skill can request file writes, branch changes, or network actions. Manual tool approvals still protect individual calls, but hook dispatch has no workspace trust or hook-level confirmation, andauto/yolomodes remove that safeguard. Allowlist trusted hook Skills and require explicit approval before mandatory hooks. Apply this to the pre/post sections in all ten affectedspeckit-*Skills, includingspeckit-plan,speckit-implement,speckit-tasks, andspeckit-taskstoissues.🧰 Tools
🪛 LanguageTool
[style] ~30-~30: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ommit
→/skill:speckit-git-commit`. - For each executable hook, output the follow...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
🪛 markdownlint-cli2 (0.23.2)
[warning] 32-32: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
[warning] 43-43: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
📍 Affects 6 files
.kimi-code/skills/speckit-analyze/SKILL.md#L21-L52(this comment).kimi-code/skills/speckit-constitution/SKILL.md#L40-L71.kimi-code/skills/speckit-converge/SKILL.md#L21-L56.kimi-code/skills/speckit-clarify/SKILL.md#L21-L52.kimi-code/skills/speckit-specify/SKILL.md#L21-L52.kimi-code/skills/speckit-checklist/SKILL.md#L51-L82🤖 Prompt for AI Agents
Source: Linters/SAST tools