Skip to content

ARQ-2140 Support for specifying the architecture for IE driver binary #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2017
Merged

ARQ-2140 Support for specifying the architecture for IE driver binary #110

merged 1 commit into from
Sep 4, 2017

Conversation

vmuzikar
Copy link
Contributor

Short description of what this resolves:

Adds the support for specifying the architecture for IE driver binary.
Includes some fixes as well - please see bellow.

Changes proposed in this pull request:

  • Basically adds ieDriverArch property. If it's not specified then it just falls back to the original behavior - downloads the binary based on the OS architecture.
  • Adds proper emptiness check for ieDriverVersion and seleniumServerVersion. Before, when those properties were specified but empty, it caused StringIndexOutOfBoundsException.

Fixes: #
StringIndexOutOfBoundsException

MatousJobanek
MatousJobanek approved these changes Sep 4, 2017
View reviewed changes
Copy link
Contributor

@MatousJobanek MatousJobanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Good job @vmuzikar 🥇

@MatousJobanek MatousJobanek merged commit 354360d into arquillian:master Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatousJobanek MatousJobanek MatousJobanek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmuzikar @MatousJobanek