Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix excluded tests for Weld injection in Jetty 12 ee9/10. Add assertion that servlets can be injected into #198

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Fix excluded tests for Weld injection in Jetty 12 ee9/10. Add assertion that servlets can be injected into #198

merged 1 commit into from
Apr 26, 2024

Conversation

manovotn
Copy link
Contributor

Fixes #197

@manovotn manovotn mentioned this pull request Apr 25, 2024
Closed
joakime
joakime approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of org.jboss.weld.environment.servlet.Listener and the additional integration points are great.

@olamy olamy added the bug label Apr 25, 2024
@manovotn
Copy link
Contributor Author

I've addressed the comment, PR should be good to go now

@olamy olamy merged commit d611907 into arquillian:master Apr 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olamy olamy olamy approved these changes

@joakime joakime joakime approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skipped assertions in Jetty 12 tests
3 participants
@manovotn @olamy @joakime