Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor warning fixes #320

Merged
merged 2 commits into from
Nov 9, 2015
Merged

Minor warning fixes #320

merged 2 commits into from
Nov 9, 2015

Conversation

jmarshall
Copy link
Contributor

  1. Another "unknown namespace" thing.
  2. Use an ostringstream to format the split filename, forever avoiding the size_t-related warning. This is an alternative to the C-style fix for this one in Minor fixes #250.

...so that namespace "std" already exists when we try to use it,
as it will have been declared by the standard headers #included.
Doing otherwise elicits a warning from Clang.
Using C++'s native facility here avoids a warning from the sprintf()
in the previous code.
@arq5x
Copy link
Owner

arq5x commented Nov 9, 2015

Sorry for the delay, John. I've been swamped. Thanks for this!

arq5x added a commit that referenced this pull request Nov 9, 2015
@arq5x arq5x merged commit 3d31735 into arq5x:master Nov 9, 2015
@jmarshall jmarshall deleted the warnings4 branch January 9, 2016 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants