This repository was archived by the owner on Apr 27, 2026. It is now read-only.
refactor(streaming_file): consolidate PR review feedback#7
Merged
Conversation
Addresses all reviewer feedback from PR warpstreamlabs#514: - Remove ShutdownTimeout field (use Bento's shutdown_timeout) - Remove Debug field (use Bento's logger.level) - Change status to experimental (default) - Improve Description with platform limitations and trade-offs - Remove generic comments that just restate function names - Remove json tags from StreamingFileInputConfig (not serialized) - Remove unused HealthStatus struct - Remove unused lastInode and lastSize fields - Use context deadline for shutdown instead of custom timeout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses all reviewer feedback from PR warpstreamlabs#514: