This repository was archived by the owner on Apr 27, 2026. It is now read-only.
refactor(streaming_file): remove Debug config field#2
Merged
Conversation
aronchick
force-pushed
the
fix/remove-debug-field
branch
from
117d762 to
ff08e65
Compare
Use Bento's existing logger.level configuration instead of a component-specific Debug flag. The logDebugf calls use Bento's logger which already respects the configured log level. This aligns with Bento idioms where logging verbosity is controlled at the stream level via logger.level rather than per-component.
aronchick
force-pushed
the
fix/remove-debug-field
branch
from
ff08e65 to
978bc01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Debugfield fromStreamingFileInputConfiglogger.levelconfiguration insteadMotivation
This addresses reviewer feedback on PR warpstreamlabs#514 - the component should use Bento's existing logger level mechanism rather than a component-specific debug flag.
Changes
Debugfield from config structdebugfield from config spec