Skip to content

Commit

Permalink
Add JsDom to server dependencies (twentyhq#4740)
Browse files Browse the repository at this point in the history
We were missing `JsDom` dependencies in the package.json generated by nx
while running `twenty-server`: `yarn nx build:packageJson`

Detailed explanation: 
- we are currently using nx paradigm which is to put dependencies of all
projets at root, which enables global package migrations for the whole
monorepo
- for production containers, we only want specific project dependency to
be added. This is done by running `yarn nx build:packageJson` on
`twenty-server`. Nx is statically analyzing twenty-server dependencies
and generating a tailored package.json that production containers can
later use.
- However, `nx` static analysis is not flawless and is missing some
packages. We are going to stop using it as the value is not there yet
but the burden for developers is high. The guideline is to put back
project dependencies into specific package `package.json`
- Therefore, I'm adding `jsdom` to twenty-server `package.json`
  • Loading branch information
charlesBochet authored Apr 2, 2024
1 parent f78abf1 commit c0c5a57
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
6 changes: 3 additions & 3 deletions packages/twenty-front/nyc.config.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ const globalCoverage = {
};

const modulesCoverage = {
statements: 75,
lines: 75,
functions: 70,
statements: 70,
lines: 70,
functions: 65,
include: ['src/modules/**/*'],
exclude: ['src/**/*.ts'],
};
Expand Down
1 change: 1 addition & 0 deletions packages/twenty-server/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
"cache-manager-redis-yet": "^4.1.2",
"class-validator": "patch:[email protected]#./patches/class-validator+0.14.0.patch",
"graphql-middleware": "^6.1.35",
"jsdom": "~22.1.0",
"jwt-decode": "^4.0.0",
"lodash.differencewith": "^4.5.0",
"lodash.uniq": "^4.5.0",
Expand Down
1 change: 1 addition & 0 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -45780,6 +45780,7 @@ __metadata:
cache-manager-redis-yet: "npm:^4.1.2"
class-validator: "patch:[email protected]#./patches/class-validator+0.14.0.patch"
graphql-middleware: "npm:^6.1.35"
jsdom: "npm:~22.1.0"
jwt-decode: "npm:^4.0.0"
lodash.differencewith: "npm:^4.5.0"
lodash.uniq: "npm:^4.5.0"
Expand Down

0 comments on commit c0c5a57

Please sign in to comment.