5180 - does not call debounced update for invalid names (twentyhq#5181)

fix: twentyhq#5180 Previously, clearing your name would kick you to the profile creation page. https://github.com/twentyhq/twenty/assets/68029599/8c0087da-6b03-4b6e-b202-eabe8ebcee18 Fixed so it checks your name is valid before calling the debounced update https://github.com/twentyhq/twenty/assets/68029599/4bc71d8f-e4f4-49ae-9cb8-497bd971be94 --------- Co-authored-by: Weiko <[email protected]>
arnavsaxena17 · Apr 26, 2024 · 59e7b7e · 59e7b7e
1 parent 0691805
commit 59e7b7e
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/packages/twenty-front/src/modules/settings/profile/components/NameFields.tsx b/packages/twenty-front/src/modules/settings/profile/components/NameFields.tsx
@@ -84,9 +84,13 @@ export const NameFields = ({
       return;
     }
 
+    const { firstName: currentFirstName, lastName: currentLastName } =
+      currentWorkspaceMember.name;
+
     if (
-      currentWorkspaceMember.name?.firstName !== firstName ||
-      currentWorkspaceMember.name?.lastName !== lastName
+      (currentFirstName !== firstName || currentLastName !== lastName) &&
+      firstName !== '' &&
+      lastName !== ''
     ) {
       debouncedUpdate();
     }