chore: add incremental typecheck to twenty-ui (twentyhq#4947)

Part of twentyhq#4766
arnavsaxena17 · Apr 15, 2024 · 3f66639 · 3f66639
1 parent 05a806f
commit 3f66639
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 7 deletions.
diff --git a/.github/workflows/ci-front.yaml b/.github/workflows/ci-front.yaml
@@ -148,6 +148,10 @@ jobs:
           path: node_modules
           key: root-node_modules-${{hashFiles('yarn.lock')}}
           restore-keys: root-node_modules-
+      - name: UI / Run linter
+        run: yarn nx lint twenty-ui
+      - name: UI / Run Typescript Check
+        run: yarn nx typecheck twenty-ui
       - name: Front / Run linter
         run: yarn nx lint:ci twenty-front
       - name: Front / Run Typescript Check

diff --git a/.gitignore b/.gitignore
@@ -23,3 +23,4 @@
 coverage
 dist
 storybook-static
+*.tsbuildinfo
diff --git a/packages/twenty-ui/project.json b/packages/twenty-ui/project.json
@@ -31,7 +31,6 @@
         ]
       },
       "configurations": {
-        "ci": { "lintFilePatterns": ["{projectRoot}/**/*.{ts,tsx,json}"] },
         "fix": { "fix": true }
       }
     },
@@ -42,6 +41,13 @@
         "jestConfig": "{projectRoot}/jest.config.ts"
       }
     },
+    "typecheck": {
+      "executor": "nx:run-commands",
+      "options": {
+        "cwd": "{projectRoot}",
+        "command": "tsc -b tsconfig.json --incremental"
+      }
+    },
     "storybook:dev": {
       "executor": "@nx/storybook:storybook",
       "options": {

diff --git a/packages/twenty-ui/tsconfig.json b/packages/twenty-ui/tsconfig.json
@@ -8,6 +8,7 @@
     "esModuleInterop": true,
     "noEmit": true,
     "types": ["node"],
+    "outDir": "../../dist/out-tsc",
     "paths": {
       "@ui/*": ["packages/twenty-ui/src/*"]
     }

diff --git a/packages/twenty-ui/tsconfig.lib.json b/packages/twenty-ui/tsconfig.lib.json
@@ -1,8 +1,5 @@
 {
   "extends": "./tsconfig.json",
-  "compilerOptions": {
-    "outDir": "../../dist/out-tsc"
-  },
   "exclude": [
     "**/*.spec.ts",
     "**/*.spec.tsx",

diff --git a/packages/twenty-ui/tsconfig.spec.json b/packages/twenty-ui/tsconfig.spec.json
@@ -1,7 +1,6 @@
 {
   "extends": "./tsconfig.json",
   "compilerOptions": {
-    "outDir": "../../dist/out-tsc",
     "module": "commonjs",
     "types": ["jest", "node"]
   },

diff --git a/packages/twenty-ui/tsconfig.storybook.json b/packages/twenty-ui/tsconfig.storybook.json
@@ -1,8 +1,7 @@
 {
   "extends": "./tsconfig.json",
   "compilerOptions": {
-    "emitDecoratorMetadata": true,
-    "outDir": ""
+    "emitDecoratorMetadata": true
   },
   "include": [
     ".storybook/*.ts",