feat(localfiles): Support relative local files to hal config home #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spinnaker#1376) * refactor(config): remove a pointless try/catch block * refactor(tests): remove an unused import * fix(config): parse 'oauthScopes' stanzas that were incorrectly written The old version of Lombok used in Halyard <=1.21 didn't copy @JsonProperty annotations to the generated methods. This means Jackson was seeing the field as 'oAuthScopes' and the getter/setter as a separate 'oauthScopes' property. The same data would be written to both properties, and during parsing whichever came last in the file would be persisted into the object. With new versions of Lombok (>=1.18.8), the @JsonProperty annotation is copied to the bean methods, so the 'oauthScopes' property disappears and Jackson can no longer parse those old files. This commit adds some methods to support parsing the files generated by previous versions of Halyard, but will no longer write out the incorrect duplicate data. * chore(copyright): add a missing copyright header
* feat(secret): decrypt secrets before sending to deck * code review changes
Remove the $REPO_NAME variable from the cloudbuild.yaml file; this is being used to decide the name of the image to push which will not always correspond to the image name. In particular, if we start publishing both alpine and ubuntu images we'll want the image name to have a suffix reflecting that.
* feat(plugins): adding halyard commands for plugins * chore(refactor): use toMap instead of a concurrentMap collector
* fix(kubernetes): Added support for tolerationn Signed-off-by: rverma-nikiai <[email protected]> * feat(kubernetes): Added support for Tolerations Added support for tolerations Signed-off-by: rverma-nikiai <[email protected]> * feat(kubernetes): Support for tolerations * fix(kubernetes): Added support for Tolerations, fixed access
… component sizing. (spinnaker#1387)
…spinnaker#1401) * refactor(deploy/kubernetes): Removed duplicated code * feat(deploy/kubernetes): Option to select the image variant to deploy Supports `slim` and `ubuntu`, the former being the default. Ubuntu image supported starting with v1.16.0.
Usually when referencing local files in main hal config with a relative path, halyard throws this error: Problems in Global: ! ERROR Failed to backup user file: default/files/kubeconfig-main - Failed to generate config. With this change, relative files will be automatically resolved relative from hal config home.
… of github.com:armory-io/halyard into test-operator � Conflicts: � halyard-deploy/src/main/java/com/netflix/spinnaker/halyard/deploy/spinnaker/v1/service/distributed/kubernetes/v2/KubernetesV2Service.java
…lative-file-references
…' into feature/relative-file-references
…io/halyard into test-operator
…io/halyard into test-operator
…io/halyard into gen-manifests-local-files
ncknt
reviewed
Sep 11, 2019
| // write all local files in hal config root | ||
| writeFile("", et.getKey(), et.getValue()); | ||
| } else { | ||
| String filePath = et.getKey().replaceAll("__", File.separator); |
There was a problem hiding this comment.
I see that service settings files are processed in writeServiceSettings, this loop processes profile files and relative resource files
ncknt
reviewed
Sep 11, 2019
...y/src/main/java/com/netflix/spinnaker/halyard/deploy/services/v1/RequestGenerateService.java
Outdated
Show resolved
Hide resolved
ncknt
approved these changes
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.