Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsmasq: Module Addresses DNS Resolver Conflict #354

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Tearran
Copy link
Member

@Tearran Tearran commented Jan 3, 2025

A module to manage the dnsmasq service. The focus was on resolving conflicts between systemd-resolved and dnsmasq, and it may need refining.

This module manages the dnsmasq service, including installation, configuration, removal, purging, and status checking. It ensures that dnsmasq is properly configured and that systemd-resolved is disabled to avoid conflicts. The focus was on resolving conflicts between systemd-resolved and dnsmasq, and it may need refining for more advanced use cases.

Issue reference:
KVM:

Implementation Details

  • Key changes introduced by this PR:

    • Disables systemd-resolved service to avoid conflicts with dnsmasq.
    • Sets up dnsmasq configuration to use 127.0.0.1 as the DNS resolver.
    • Provides functions to install, configure, remove, purge, and check the status of dnsmasq.
    • Ensures dnsmasq starts on boot and handles DNS resolution properly.
  • Justification for the changes:

    • Resolves conflicts between systemd-resolved and dnsmasq.
    • Provides advanced DNS resolution features using dnsmasq.
  • Confirmation that no new external dependencies or modules have been introduced:

    • No new external dependencies or modules have been introduced in this PR.

Documentation Summary

  • Metadata Included:

    • Yes, the metadata (associative arrays) are included in the code. Metadata for modules, jobs, and runtime have been updated appropriately.
  • Document Generated:

    • Yes, the updated documentation has been generated using armbian-configng --doc. The README.md has been updated to reflect the changes.

Testing Procedure

  • Test 1:

    • Description: Tested the installation and configuration of dnsmasq by logging in via SSH (ssh@hostname) and accessing Webmin (https://hostname:10000).
    • Results: Dnsmasq was installed and configured successfully, and systemd-resolved was disabled without any issues. DNS resolution worked as expected.
  • Test 2:

    • Description: Tested the removal and purging of dnsmasq.
    • Results: Dnsmasq was removed and purged successfully, and the system reverted to its original DNS configuration without conflicts.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have ensured that my changes do not introduce new warnings or errors
  • No new external dependencies are included
  • Changes have been tested and verified
  • I have included necessary metadata in the code, including associative arrays

@github-actions github-actions bot added the size/medium PR with more then 50 and less then 250 lines label Jan 3, 2025
@Tearran Tearran changed the title Add dnsmasq # dnsmasq: Addresses DNS Resolver Conflict Jan 3, 2025
@Tearran Tearran added the Work in progress Unfinished / work in progress label Jan 4, 2025
@Tearran Tearran changed the title # dnsmasq: Addresses DNS Resolver Conflict dnsmasq: Module Addresses DNS Resolver Conflict Jan 4, 2025
@Tearran Tearran marked this pull request as ready for review January 4, 2025 06:24
@Tearran Tearran marked this pull request as draft January 4, 2025 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/medium PR with more then 50 and less then 250 lines Work in progress Unfinished / work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant