Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve welcome page, adjust contribution.md, add licence #331

Merged
merged 4 commits into from
Dec 30, 2024
Merged

Improve welcome page, adjust contribution.md, add licence #331

merged 4 commits into from
Dec 30, 2024

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Dec 22, 2024 •
edited
Loading

Description

Reworking welcome page.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • No new external dependencies are included

@github-actions github-actions bot added GitHub GitHub-related changes like labels, templates, ... Documentation Documentation changes or additions size/large PR with 250 lines or more labels Dec 22, 2024
@igorpecovnik igorpecovnik added 02 Milestone: First quarter release Needs review Seeking for review Documentation Documentation changes or additions and removed size/large PR with 250 lines or more GitHub GitHub-related changes like labels, templates, ... Documentation Documentation changes or additions labels Dec 22, 2024
@igorpecovnik igorpecovnik changed the title Improve welcome page, add new image, adjust contribution.md, add licence Improve welcome page, adjust contribution.md, add licence Dec 22, 2024
@github-actions github-actions bot added GitHub GitHub-related changes like labels, templates, ... size/large PR with 250 lines or more labels Dec 24, 2024
@igorpecovnik igorpecovnik requested a review from Tearran December 24, 2024 21:19
Tearran
Tearran previously approved these changes Dec 28, 2024
View reviewed changes
Copy link
Member

@Tearran Tearran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@Tearran Tearran dismissed their stale review December 28, 2024 02:31

unit test failed after updating branch

@Tearran Tearran self-requested a review December 28, 2024 02:34
Tearran
Tearran approved these changes Dec 28, 2024
View reviewed changes
Copy link
Member

@Tearran Tearran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re run failed unit test and passing.

Still looks great

@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Dec 30, 2024
@igorpecovnik igorpecovnik merged commit ed7eb92 into main Dec 30, 2024
79 checks passed
@igorpecovnik igorpecovnik deleted the read branch December 30, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tearran Tearran Tearran approved these changes

Assignees
No one assigned
Labels
02 Milestone: First quarter release Documentation Documentation changes or additions GitHub GitHub-related changes like labels, templates, ... Ready to merge Reviewed, tested and ready for merge size/large PR with 250 lines or more
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igorpecovnik @Tearran