Add missing deps for armbian-config #7562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armbian-config uses debconf-apt-progress which is part of debconf. libtext-iconv-perl is needed to prevent the following error, when uninstalling a package through debconf-apt-progress: Can't locate object method "new" via package "Text::Iconv" (perhaps you forgot to load "Text::Iconv"?) at /usr/share/perl5/Debconf/Encoding.pm line 65, <GEN2> line 2. dpkg: error processing package nfs-common (--configure):
github-actions
bot
added
size/small
6 tasks
igorpecovnik
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Agree. Made a new task related to this https://armbian.atlassian.net/browse/AR-2562
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
armbian-configusesdebconf-apt-progresswhich is part ofdebconf, so it should be listed as a dependency, and missinglibtext-iconv-perlcauses an error as described in armbian/configng#272 (comment).How Has This Been Tested?
debconfis obvious. It's also pulled in by a number of other packages, so it hasn't come up as a problem. But, sincearmbian-configuses it directly, it should specify it as a direct dependency.libtext-iconv-perlis a bit less obvious. It's probably also pulled in by other packages on most systems, so it hasn't been caught before. But, on a minimal Armbian image where it's not present, I was getting the error mentioned above. Manually installing this package handled the error.Checklist:
Please delete options that are not relevant.