Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AirflowOperator - Capitalize armada in log messages to Armada #3909

Merged
merged 2 commits into from
Sep 5, 2024
Merged

AirflowOperator - Capitalize armada in log messages to Armada #3909

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef86196
AirflowOperator - Capitalize armada in log messages to Armada
masipauskas Sep 5, 2024
e1437c0
Merge branch 'master' into masipauskas-patch-2
masipauskas Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions third_party/airflow/armada/operators/armada.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ def on_kill(self) -> None:
if self.job_context is not None:
self.log.info(
f"on_kill called, "
f"cancelling armada job with job-id {self.job_context.job_id} in queue "
f"cancelling Armada job with job-id {self.job_context.job_id} in queue "
f"{self.job_context.armada_queue}"
)
self.hook.cancel_job(self.job_context)
Expand Down Expand Up @@ -264,7 +264,7 @@ def _reattach_or_submit_job(
)
if existing_run is not None:
self.log.info(
"Attached to existing armada job "
"Attached to existing Armada job "
f"with job-id {existing_run['armada_job_id']}."
f" {self._trigger_tracking_message(existing_run['armada_job_id'])}"
)
Expand All @@ -278,7 +278,7 @@ def _reattach_or_submit_job(
# We haven't got a running job, submit a new one and persist state to xcom.
ctx = self.hook.submit_job(self.armada_queue, job_set_id, job_request)
tracking_msg = self._trigger_tracking_message(ctx.job_id)
self.log.info(f"Submitted job to armada with job-id {ctx.job_id}. {tracking_msg}")
self.log.info(f"Submitted job to Armada with job-id {ctx.job_id}. {tracking_msg}")

ti.xcom_push(
key=f"{ti.try_number}",
Expand Down