Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully shutdown components #302

Closed
JamesMurkin opened this issue Jan 21, 2020 · 0 comments
Closed

Gracefully shutdown components #302

JamesMurkin opened this issue Jan 21, 2020 · 0 comments

Comments

@JamesMurkin
Copy link
Contributor

We should improve our components so they can be gracefully shutdown and terminate open connections before doing so.

Example:
Run server component
Run armadactl to watch some job-set against the server component

When you try to stop the server component, it'll hang and not shut down quickly, due to the open connection.

Things to do:

  • Make components gracefully shutdown even when there are open connections
  • Make sure it can shutdown faster than the default terminationGracePeriodSeconds, which is currently 5s

Especially for the server, doing this should prevent event loss when the server is forcefully shut down. Potentially it'd be shutdown mid processing of an event.

@kannon92 kannon92 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 1, 2023
svc-gh-ghzonetrans-p pushed a commit that referenced this issue Dec 10, 2024
* wip

* wip

* wip

* tests

* Add spot price for fair-share scheduled pools (#301) (#4079)

* wip

* wip

* wip

* tests

Co-authored-by: Christopher Martin <[email protected]>

* tests

* fix metrics

---------

Co-authored-by: Chris Martin <[email protected]>
JamesMurkin pushed a commit that referenced this issue Dec 11, 2024
* Add spot price for fair-share scheduled pools (#301)

* wip

* wip

* wip

* tests

* Fixes to fair-share spot price following testing (#302)

* wip

* wip

* wip

* tests

* Add spot price for fair-share scheduled pools (#301) (#4079)

* wip

* wip

* wip

* tests

Co-authored-by: Christopher Martin <[email protected]>

* tests

* fix metrics

---------

Co-authored-by: Chris Martin <[email protected]>

---------

Co-authored-by: Christopher Martin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants