Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update pruning pods to use different labels and add unit test #336

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

Sovietaced
Copy link
Contributor

@Sovietaced Sovietaced commented Nov 18, 2024

Pull Request Template

Fixes #335

Also introduces protocmp as a way to make assertions on entire proto structs instead of cherry picking assertions on individual fields. This should make unit test much more robust moving forward if used.

Type of change

Please select the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code Style Update (formatting, renaming)
  • Refactor (code changes that do not fix a bug or add a feature)
  • Documentation Update
  • Other (please describe):

How Has This Been Tested?

See new unit tests

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@Sovietaced
Copy link
Contributor Author

I will follow up with a similar change for the db migrator.

@Sovietaced Sovietaced marked this pull request as ready for review November 18, 2024 08:08
@Sovietaced Sovietaced changed the title fix: Update db pruner to use different labels and add unit test fix: Update pruning pods to use different labels and add unit test Nov 18, 2024
@dejanzele dejanzele merged commit 6633b3f into armadaproject:main Nov 19, 2024
15 checks passed
@Sovietaced Sovietaced deleted the issue-335 branch November 19, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lookout service sends traffic to the Lookout DB Pruner when its running
2 participants