Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Cleanup permission group mappings #331

Merged
merged 1 commit into from
Oct 21, 2024
Merged

docs: Cleanup permission group mappings #331

merged 1 commit into from
Oct 21, 2024

Conversation

Sovietaced
Copy link
Contributor

@Sovietaced Sovietaced commented Oct 18, 2024 •
edited
Loading

Description

This pull request cleans up documentation so that it is current with recent versions of Armada.

Type of change

Please select the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code Style Update (formatting, renaming)
  • Refactor (code changes that do not fix a bug or add a feature)
  • Documentation Update
  • Other (please describe):

How Has This Been Tested?

We are using auth in production.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Sovietaced
Sovietaced commented Oct 18, 2024
View reviewed changes
README.md
reprioritize_jobs: ["everyone"]
reprioritize_any_jobs: ["everyone"]
watch_events: ["everyone"]
watch_all_events: ["everyone"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scheduler only checks for execute_jobs

Sovietaced
Sovietaced commented Oct 18, 2024
View reviewed changes
dev/quickstart/armada-crs.yaml
@@ -25,17 +25,12 @@ spec:
auth:
anonymousAuth: true
permissionGroupMapping:
submit_jobs: ["everyone"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many of these permissions are obsolete / unused

@Sovietaced Sovietaced marked this pull request as ready for review October 18, 2024 21:07
@dejanzele
Copy link
Member

Hi @Sovietaced,

Thanks for improving the docs!

@dejanzele dejanzele merged commit c2d681d into armadaproject:main Oct 21, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dejanzele dejanzele dejanzele approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sovietaced @dejanzele