Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for profiling service and ingress in armada components #330

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

dejanzele
Copy link
Member

Pull Request Template

Description

Please include a summary of the changes and the related issue (if any). Describe your changes in detail to help reviewers understand your contribution.

  • What is the purpose of this PR?
    Add support for Service and Ingress for profiling (pprof) server
  • What was changed?
    Added new Service and Ingress resources to components
  • Why was it changed?
    To be aligend with the Armada Helm charts
  • Does this address any existing issues or enhancement requests?

Fixes #319

Type of change

Please select the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code Style Update (formatting, renaming)
  • Refactor (code changes that do not fix a bug or add a feature)
  • Documentation Update
  • Other (please describe):

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions to reproduce these tests. List any relevant details for your test configuration.

  • Test Configuration:

    • Kubernetes Version:
    • Helm Version:
    • OS:
  • Test Steps:

    1. Step 1
    2. Step 2
    3. ...

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@dejanzele dejanzele force-pushed the feat/profiling-ingress branch 4 times, most recently from 09a9b44 to 576c0bd Compare October 1, 2024 14:06
nikola-jokic
nikola-jokic previously approved these changes Oct 2, 2024
Copy link

@nikola-jokic nikola-jokic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dejanzele dejanzele merged commit 98e12f9 into main Oct 8, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new config to the operator from the helm chart
3 participants