fix: Reference service accounts in deployments #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Parraga <[email protected]>
Sovietaced
changed the title
|
Hi @Sovietaced, Thanks for working on this. Could we add an explicit field called Not in all cases will the ServiceAccount match the component name |
Sure, do you want me to add the plumbing for the custom service account as well? I see that is part of the common spec now. |
Signed-off-by: Jason Parraga <[email protected]>
dejanzele
approved these changes
Jul 24, 2024
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into issues where we were specifying image pull secrets for service accounts but they were not effective since the deployments did not reference the service accounts.
Unfortunately the unit tests use pretty broad mock assertions so this does not impact the unit tests.