chore: massive redo of Operator #295
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #295 +/- ##
=======================================
Coverage 84.19% 84.19%
=======================================
Files 15 15
Lines 3441 3461 +20
=======================================
+ Hits 2897 2914 +17
- Misses 381 383 +2
- Partials 163 164 +1 ☔ View full report in Codecov by Sentry. |
| go-version: | ||
| description: "Version of Go. Default 1.21" | ||
| required: false | ||
| default: "1.21" |
There was a problem hiding this comment.
We should ask the GR guys some time if they have any interest in updating the armada repo to Go 1.21. (I've been building Armada with 1.21.1 and it seems to work fine).
| @@ -56,7 +56,7 @@ you should have a fully functional install of Armada running. | |||
|
|
|||
| To stop the development cluster: | |||
| ```bash | |||
| make dev-teardown | |||
| make delete-dev-cluster | |||
| @@ -44,10 +46,36 @@ var _ webhook.Defaulter = &EventIngester{} | |||
| func (r *EventIngester) Default() { | |||
| eventingesterlog.Info("default", "name", r.Name) | |||
|
|
|||
| // TODO(user): fill in your defaulting logic. | |||
| // image | |||
There was a problem hiding this comment.
Now is probably not the time for it, but a number of these defaulting-logic chunks are so similar, maybe it would be worthwhile to some day make a SetSpecDefaults(spec *XXXSpec) - but we'd have to define a generic meta-spec type, or make all those XXXSpec types interfaces?
There was a problem hiding this comment.
I guess I can do it in the next pass
| oldComponents.Deployment.Spec = newComponents.Deployment.Spec | ||
| oldComponents.Deployment.Labels = newComponents.Deployment.Labels | ||
| oldComponents.Deployment.Annotations = newComponents.Deployment.Annotations | ||
| func (cc *CommonComponents) ReconcileComponents(newComponents *CommonComponents) { |
There was a problem hiding this comment.
I always preferr to have the same name for the receiver
Fixes https://github.com/G-Research/gr-oss/issues/478