Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in FVP invocation #62

Merged
merged 4 commits into from
Feb 3, 2025
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def main():
help="optional arguments for the image",
)
args = parser.parse_args()
return run_fvp(
ret_code = run_fvp(
args.fvp_install_dir,
args.fvp_config_dir,
args.fvp_model,
Expand Down
14 changes: 12 additions & 2 deletions arm-software/embedded/arm-runtimes/test-support/run_fvp.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,18 @@ def run_fvp(
command.extend(["--quiet"])
for config in fvp_configs:
command.extend(["--config-file", path.join(fvp_config_dir, config + ".cfg")])
command.extend(["--application", image])

if fvp_model == "corstone-310":
command.extend(["--application", f"cpu0={image}"])
elif fvp_model == "aem-a" or fvp_model == "aem-r":
# In case we ever need to run multiprocessor images, the instance name below
# can be renamed to "cluster0.cpu*" (wildcard).
command.extend(["--application", f"cluster0.cpu0={image}"])
else:
raise RuntimeError(
f"FVP model {fvp_model} not covered in --application definition"
)

command.extend(["--parameter", f"{model.cmdline_param}={shlex.join(arguments)}"])
command.extend(["--plugin", path.join(fvp_install_dir, model.crypto_plugin)])
if tarmac_file is not None:
Expand Down Expand Up @@ -94,4 +105,3 @@ def run_fvp(
)
sys.stdout.buffer.write(result.stdout)
return result.returncode