Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

Publish some generators xy values #150

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

davxy
Copy link
Contributor

@davxy davxy commented Feb 6, 2023

This is a trivial PR that just exposes some of the parameters used to construct curves generators.

In particular the current code only exposes the ed-on-bls12-377 and ed-on-bls12-381 values.

The requirement to publish these values stems from our requirement to use the values in our custom curve configs (without copy the values directly in our code).

Furthermore there are half of the curves where these values are already set as public (thus this work will uniform the API as well)

If there are no contraindications and you are ok with it (before merging this) I'm going to iterate the same silly modification to other curves as well.

@Pratyush
Copy link
Member

Pratyush commented Feb 6, 2023

Sure, this is a good idea!.

@davxy
Copy link
Contributor Author

davxy commented Feb 8, 2023

@Pratyush done. Thank you

@mmagician mmagician merged commit 4ab8ba6 into arkworks-rs:master Mar 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants