Skip to content

Multi pairing bench#673

Merged
Pratyush merged 4 commits intoarkworks-rs:masterfrom
NP-Eng:multi-pairing-bench
Sep 4, 2023
Merged

Multi pairing bench#673
Pratyush merged 4 commits intoarkworks-rs:masterfrom
NP-Eng:multi-pairing-bench

Conversation

@mmagician
Copy link
Copy Markdown
Member

Description

Related to #617 (comment)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@mmagician mmagician requested review from a team as code owners September 2, 2023 21:14
@mmagician mmagician requested review from Pratyush and weikengchen and removed request for a team September 2, 2023 21:14
@Pratyush
Copy link
Copy Markdown
Member

Pratyush commented Sep 3, 2023

Should this be merged before or after #617?

@mmagician
Copy link
Copy Markdown
Member Author

mmagician commented Sep 4, 2023

Independent! Although without #617 the tests against curves will fail temporarily. Benches are unaffected

@Pratyush Pratyush merged commit 10acb5c into arkworks-rs:master Sep 4, 2023
@mmagician mmagician deleted the multi-pairing-bench branch September 4, 2023 11:54
aleasims pushed a commit to NilFoundation/arkworks-algebra that referenced this pull request Oct 18, 2023
aleasims added a commit to NilFoundation/arkworks-algebra that referenced this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants