This repository has been archived by the owner on Nov 16, 2021. It is now read-only.
Support being provided with a SVG as a string #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkon
suggested changes
May 19, 2018
src/inline-svg.directive.ts
Outdated
| // Check if a URL was actually passed into the directive | ||
| if (!this.inlineSVG) { | ||
| // Check if a URL/string was actually passed into the directive | ||
| if (!this.inlineSVG && !this.isSVGString) { |
There was a problem hiding this comment.
Just leave it as a single check and reword the failure message.
src/inline-svg.directive.ts
Outdated
| } | ||
|
|
||
| if (this.isSVGString) { | ||
| this.insertSvgElement(this._svgElementFromString(this.inlineSVG)); |
There was a problem hiding this comment.
Can you refactor it so we get the SVG here, and then call insertSvgElement with it?
|
Hi, can this be merged? Any changes required? |
|
Master has changed since this PR was posted, and this PR can't be merged without adaptions. The reason it wasn't merged, is that the repo creator redecided on the approach to solving my initial problem. I still think the implementation this PR provides is the simplest and most versatile solution, as I believe the responses in the corresponding issue has proven to confirm: ://github.com//issues/75 What do you think @arkon ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #75